Hi Gene,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on ljones-mfd/for-mfd-next]
[cannot apply to v5.4-rc4 next-20191024]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Gene-Chen/mfd-mt6360-add-pmic-mt6360-driver/20191024-182129
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: mips-allmodconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from <command-line>:0:0:
   include/linux/mfd/mt6360-private.h: In function 'mt6360_pdata_apply_helper':
>> include/linux/mfd/mt6360-private.h:271:9: error: implicit declaration of function 'regmap_update_bits'; did you mean 'work_data_bits'? [-Werror=implicit-function-declaration]
      ret = regmap_update_bits(context,
            ^~~~~~~~~~~~~~~~~~
            work_data_bits
   cc1: some warnings being treated as errors

vim +271 include/linux/mfd/mt6360-private.h

   258	
   259	static inline int mt6360_pdata_apply_helper(void *context, void *pdata,
   260						   const struct mt6360_pdata_prop *prop,
   261						   int prop_cnt)
   262	{
   263		int i, ret;
   264		u32 val;
   265	
   266		for (i = 0; i < prop_cnt; i++) {
   267			val = *(u32 *)(pdata + prop[i].offset);
   268			if (prop[i].transform)
   269				val = prop[i].transform(val);
   270			val += prop[i].base;
 > 271			ret = regmap_update_bits(context,
   272				     prop[i].reg, prop[i].mask, val << prop[i].shift);
   273			if (ret < 0)
   274				return ret;
   275		}
   276		return 0;
   277	}
   278	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation