From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3999BCA9EA0 for ; Fri, 25 Oct 2019 17:29:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1283D21872 for ; Fri, 25 Oct 2019 17:29:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2409987AbfJYR3N (ORCPT ); Fri, 25 Oct 2019 13:29:13 -0400 Received: from mx2.suse.de ([195.135.220.15]:33728 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388862AbfJYR3M (ORCPT ); Fri, 25 Oct 2019 13:29:12 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9CA70AEFF; Fri, 25 Oct 2019 17:29:11 +0000 (UTC) Date: Fri, 25 Oct 2019 10:27:49 -0700 From: Davidlohr Bueso To: Peter Zijlstra Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: Re: [PATCH -tip] locking/mutex: Complain upon api misuse wrt interrupt context Message-ID: <20191025172749.ugi3hcehqbldit7i@linux-p48b> References: <20191025033634.3330-1-dave@stgolabs.net> <20191025081037.GF4131@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20191025081037.GF4131@hirez.programming.kicks-ass.net> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 25 Oct 2019, Peter Zijlstra wrote: >No real objection, but should not lockdep already complain about this? >__mutex_unlock_slowpath() takes ->wait_lock irq-unsafe, so then using it >from an IRQ should generate an insta IRQ inversion report. But we still have the unlock fastpath and the trylock scenarios which don't take locks. Thanks, davidlohr