mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Campello <campello@chromium.org>
To: Nick Crews <ncrews@chromium.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Benson Leung <bleung@chromium.org>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Duncan Laurie <dlaurie@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Wei Yongjun <weiyongjun1@huawei.com>
Subject: Re: [PATCH v6] platform/chrome: wilco_ec: Add Wilco EC keyboard backlight LEDs support
Date: Fri, 25 Oct 2019 11:35:47 -0600	[thread overview]
Message-ID: <20191025173547.GB1768@chromium.org> (raw)
In-Reply-To: <CAHX4x86+1dNkGHUDvYcC_OhSyTPRcg8UJLAZKCdjmnwVWDOC+A@mail.gmail.com>

Thanks Nick for taking care of this. I just reviewed your patch
in the other thread. Also, thanks Enric for your comments.

Thanks again.
Daniel

On Thu, Oct 24, 2019 at 04:18:07PM -0600, Nick Crews wrote:
> Thanks for getting this going again Daniel. This version of
> the patch is fairly old, and after so long I've found some
> things about it that I don't like, even though I wrote it
> originally :). One of the main things was how complicated it
> was, and how there was duplicated code in core.c and the
> kbd_backlight_leds.c.
>
> Therefore, I just sent a newer version of this that simplifies
> things greatly, and addresses the feedback that Enric just gave.
> Check for that patch (it's paired with another unrelated one)
> and see what you think.
>
> Cheers,
> Nick
>
> On Thu, Oct 24, 2019 at 3:54 AM Enric Balletbo i Serra
> <enric.balletbo@collabora.com> wrote:
> >
> > Hi Daniel,
> >
> > Some few comments, mostly nits. In general I'm fine with it.
> >
> > Thanks,
> >  Enric

      reply	other threads:[~2019-10-25 17:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18 18:09 Daniel Campello
2019-10-24  9:54 ` Enric Balletbo i Serra
2019-10-24 22:18   ` Nick Crews
2019-10-25 17:35     ` Daniel Campello [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191025173547.GB1768@chromium.org \
    --to=campello@chromium.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=arnd@arndb.de \
    --cc=bleung@chromium.org \
    --cc=dlaurie@google.com \
    --cc=enric.balletbo@collabora.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncrews@chromium.org \
    --cc=tglx@linutronix.de \
    --cc=weiyongjun1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®