From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3CA2CA9EA0 for ; Fri, 25 Oct 2019 20:25:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8DD8921D81 for ; Fri, 25 Oct 2019 20:25:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728272AbfJYUZj (ORCPT ); Fri, 25 Oct 2019 16:25:39 -0400 Received: from ale.deltatee.com ([207.54.116.67]:35304 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728077AbfJYUZj (ORCPT ); Fri, 25 Oct 2019 16:25:39 -0400 Received: from cgy1-donard.priv.deltatee.com ([172.16.1.31]) by ale.deltatee.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iO69R-00078b-Ir; Fri, 25 Oct 2019 14:25:38 -0600 Received: from gunthorp by cgy1-donard.priv.deltatee.com with local (Exim 4.92) (envelope-from ) id 1iO69Q-00038u-Ip; Fri, 25 Oct 2019 14:25:36 -0600 From: Logan Gunthorpe To: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Cc: Christoph Hellwig , Sagi Grimberg , Keith Busch , Chaitanya Kulkarni , Max Gurtovoy , Stephen Bates , Logan Gunthorpe Date: Fri, 25 Oct 2019 14:25:32 -0600 Message-Id: <20191025202535.12036-1-logang@deltatee.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 172.16.1.31 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me, kbusch@kernel.org, Chaitanya.Kulkarni@wdc.com, maxg@mellanox.com, sbates@raithlin.com, logang@deltatee.com X-SA-Exim-Mail-From: gunthorp@deltatee.com Subject: [RFC PATCH 0/3] Passthru Execute Request Interface X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, This is just an RFC meant to get some early feedback on the core interface for executing passthru commands that will be needed in the upcomming nvmet passth patchset. The first patch moves the calls to nvme_passthru_[start|end]() into a common helper such that all passthru requests will call them. The second patch does a bit of code reorganization for the third patch. The third patch proposes a new nvme_execute_passthru_rq_nowait() interface for the nvmet passthru code. For commands that have no effects it is simply equivalent to blk_execute_rq_nowait(). For commands that has effects, it pushes the command submission to a work queue. This requires adding a work struct to nvme_request. The code that will use this interfcae can be seen in the WIP passthru patch[1]. It helps clean things up considerably from the last submission of the patch. Thanks, Logan [1] https://github.com/sbates130272/linux-p2pmem/commit/a468e458795e6df6483ad8c98635536d6da31064 -- Logan Gunthorpe (3): nvme: Move nvme_passthru_[start|end]() calls to common code nvme: Create helper function to obtain command effects nvme: Introduce nvme_execute_passthru_rq_nowait() drivers/nvme/host/core.c | 228 ++++++++++++++++++++++++--------------- drivers/nvme/host/nvme.h | 7 ++ 2 files changed, 147 insertions(+), 88 deletions(-) -- 2.20.1