From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE926C47E49 for ; Sun, 27 Oct 2019 23:00:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A0AD42067B for ; Sun, 27 Oct 2019 23:00:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="OV2CgShd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728407AbfJ0XAu (ORCPT ); Sun, 27 Oct 2019 19:00:50 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:46707 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727529AbfJ0XAu (ORCPT ); Sun, 27 Oct 2019 19:00:50 -0400 Received: by mail-qt1-f193.google.com with SMTP id u22so11919012qtq.13 for ; Sun, 27 Oct 2019 16:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9ucr+jOcw3G+VDCL6bizb9oLtSAC2iKYHZ/39iZyP6o=; b=OV2CgShdRhqoNNuh4gbrtksfZElzZUHAb57UbiuZhnU1xLoiveAmCzm1DzSSYASDHn 9lJpIQbgUKKaiyYxu40d1CpFhWp84+z4TwVstxtXgsD4wz/jQE5n1rX/OzIw7eNZzFHh eZxNguN4xn6tOleZqlQBPnoEFoFZwhCDmM3vJ4LWqvbCCibzLP5wToSVU4qz3uq2mww/ uBkKdiRGtfmV4CASLDB8vXJTpsThgGvM1zF9RxrObiAuZujbn5xPF7S38gE4NftznuMm kqB2ijpfcE/H1cWfy37qxyz52rS1XxSce03fxlyCv0lr+0DDyvZoH5d4u0vCIPyN1Lag 0PZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9ucr+jOcw3G+VDCL6bizb9oLtSAC2iKYHZ/39iZyP6o=; b=Zf5c1bwJSv0tPHdjSOJwFpqoDVkXo7qIs8ww0LD93YLcwISSrEHbJgyK4Ny9+uLfT1 n+uKd6TXQ6zc0x7i+XNeiijIn1K65whajQvrZqjyxPJJmJLz+PvJvN3RnfZyOm2rK5k0 ma8jhRheURdDsTx7BDU1NOK9j9mS447YFx4AMVkKYUGmym/Zo0I5M1vwkYNZMyLcRNN/ YqJjPtVu763WwdcrJ6NjAx3QHUklrEw3vELChdy9fpgwyAO76nZ00IISesePJr4xcPb9 R6Urb9btZizVJG304GvX6dCgVS2JEHum6dF+1J2E2tnYi09ZSC4baxwZjw8aF1uUx/vl lHwg== X-Gm-Message-State: APjAAAUcy0jUPrD1SvMY07OYMNp/O4Ezj4fHpsrikQdZ8Z4aYigSoL09 gIZ4Ji4dhK6tw86pK6OWxIDCoQ== X-Google-Smtp-Source: APXvYqyWWhFTjCpEDYO5sVHAoYLVIqrn3UnoarAWxToW7OUg/nbZFBuA+Hp6+fNIahsOmiHNpEuZoA== X-Received: by 2002:a0c:8d03:: with SMTP id r3mr2798634qvb.12.1572217247559; Sun, 27 Oct 2019 16:00:47 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-180.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.180]) by smtp.gmail.com with ESMTPSA id s21sm6675858qtc.12.2019.10.27.16.00.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 27 Oct 2019 16:00:46 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1iOrWg-0006CW-4I; Sun, 27 Oct 2019 20:00:46 -0300 Date: Sun, 27 Oct 2019 20:00:46 -0300 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: Jerry Snitselaar , linux-kernel@vger.kernel.org, Peter Huewe , linux-integrity@vger.kernel.org Subject: Re: [PATCH] tpm: Add major_version sysfs file Message-ID: <20191027230046.GJ23952@ziepe.ca> References: <20191025142847.14931-1-jsnitsel@redhat.com> <20191027153541.GA5222@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191027153541.GA5222@linux.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 27, 2019 at 05:35:41PM +0200, Jarkko Sakkinen wrote: > On Fri, Oct 25, 2019 at 07:28:47AM -0700, Jerry Snitselaar wrote: > > Easily determining what TCG version a tpm device implements > > has been a pain point for userspace for a long time, so > > add a sysfs file to report the tcg version of a tpm device. > > > > Cc: Jarkko Sakkinen > > Cc: Peter Huewe > > Cc: Jason Gunthorpe > > Cc: linux-integrity@vger.kernel.org > > Signed-off-by: Jerry Snitselaar > > Please use version_major (e.g. if there is ever version_minor > they order nicely alphabetically). That is not the convention in sysfs Jason