From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF3C6CA9EAF for ; Mon, 28 Oct 2019 01:13:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C3A9620679 for ; Mon, 28 Oct 2019 01:13:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729199AbfJ1BNJ (ORCPT ); Sun, 27 Oct 2019 21:13:09 -0400 Received: from mga18.intel.com ([134.134.136.126]:57247 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727509AbfJ1BNJ (ORCPT ); Sun, 27 Oct 2019 21:13:09 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Oct 2019 18:13:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,238,1569308400"; d="scan'208";a="224486495" Received: from lkp-server01.sh.intel.com (HELO lkp-server01) ([10.239.97.150]) by fmsmga004.fm.intel.com with ESMTP; 27 Oct 2019 18:13:02 -0700 Received: from kbuild by lkp-server01 with local (Exim 4.89) (envelope-from ) id 1iOtag-0004hM-6I; Mon, 28 Oct 2019 09:13:02 +0800 Date: Mon, 28 Oct 2019 09:12:52 +0800 From: kbuild test robot To: Alastair D'Silva Cc: kbuild-all@lists.01.org, alastair@d-silva.org, Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Dan Williams , Vishal Verma , Dave Jiang , Keith Busch , Ira Weiny , Anton Blanchard , Krzysztof Kozlowski , David Gibson , =?iso-8859-1?Q?C=E9dric?= Le Goater , Thomas Gleixner , Hari Bathini , Mahesh Salgaonkar , Greg Kurz , Masahiro Yamada , Alexey Kardashevskiy , Nicholas Piggin , Andrew Morton , David Hildenbrand , Oscar Salvador , Michal Hocko , Pavel Tatashin , Wei Yang , Qian Cai , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-mm@kvack.org Subject: [RFC PATCH] nvdimm: scm_get() can be static Message-ID: <20191028011252.ebr7djanid6k25ok@4978f4969bb8> References: <20191025044721.16617-9-alastair@au1.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191025044721.16617-9-alastair@au1.ibm.com> X-Patchwork-Hint: ignore User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes: 0d40f55b9035 ("nvdimm: Add driver for OpenCAPI Storage Class Memory") Signed-off-by: kbuild test robot --- ocxl-scm.c | 4 ++-- ocxl-scm_internal.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/nvdimm/ocxl-scm.c b/drivers/nvdimm/ocxl-scm.c index f4e6cc022de8a..c169cb0bc71d4 100644 --- a/drivers/nvdimm/ocxl-scm.c +++ b/drivers/nvdimm/ocxl-scm.c @@ -733,7 +733,7 @@ static void scm_put(struct scm_data *scm_data) put_device(&scm_data->dev); } -struct scm_data *scm_get(struct scm_data *scm_data) +static struct scm_data *scm_get(struct scm_data *scm_data) { return (get_device(&scm_data->dev) == NULL) ? NULL : scm_data; } @@ -2142,7 +2142,7 @@ static int scm_probe(struct pci_dev *pdev, const struct pci_device_id *ent) return -ENXIO; } -struct pci_driver scm_pci_driver = { +static struct pci_driver scm_pci_driver = { .name = "ocxl-scm", .id_table = scm_pci_tbl, .probe = scm_probe, diff --git a/drivers/nvdimm/ocxl-scm_internal.c b/drivers/nvdimm/ocxl-scm_internal.c index e7c247835817b..ee11fb72e1ecd 100644 --- a/drivers/nvdimm/ocxl-scm_internal.c +++ b/drivers/nvdimm/ocxl-scm_internal.c @@ -64,8 +64,8 @@ int scm_admin_command_request(struct scm_data *scm_data, u8 op_code) return scm_command_request(scm_data, &scm_data->admin_command, op_code); } -int scm_command_response(const struct scm_data *scm_data, - const struct command_metadata *cmd) +static int scm_command_response(const struct scm_data *scm_data, + const struct command_metadata *cmd) { u64 val; u16 id;