From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Cristiane Naves <cristianenavescardoso09@gmail.com>,
outreachy-kernel@googlegroups.com, devel@driverdev.osuosl.org,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [RESEND PATCH 1/2] staging: rtl8712: Fix Alignment of open parenthesis
Date: Mon, 28 Oct 2019 11:01:13 +0300 [thread overview]
Message-ID: <20191028080113.GD1944@kadam> (raw)
In-Reply-To: <25960b2a5dfe3f5f2c6579ef718f90a139ba84d7.camel@perches.com>
On Fri, Oct 25, 2019 at 06:50:25PM -0700, Joe Perches wrote:
> On Fri, 2019-10-25 at 22:09 -0300, Cristiane Naves wrote:
> > Fix alignment should match open parenthesis.Issue found by checkpatch.
>
> Beyond doing style cleanups, please always try
> to make the code more readable.
>
> > diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
> []
> > @@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv,
> > precvbuf->ref_cnt = 0;
> > precvbuf->adapter = padapter;
> > list_add_tail(&precvbuf->list,
> > - &(precvpriv->free_recv_buf_queue.queue));
> > + &(precvpriv->free_recv_buf_queue.queue));
>
> Please remove the unnecessary parentheses too
>
Removing the parentheses increases your chance of the patch being
rejected on the one thing per patch rule...
regards,
dan carpenter
next prev parent reply other threads:[~2019-10-28 8:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-26 1:09 [RESEND PATCH 0/2] Cleanup in rtl8712 Cristiane Naves
2019-10-26 1:09 ` [RESEND PATCH 1/2] staging: rtl8712: Fix Alignment of open parenthesis Cristiane Naves
2019-10-26 1:50 ` Joe Perches
2019-10-28 8:01 ` Dan Carpenter [this message]
2019-10-28 8:09 ` Joe Perches
2019-10-26 18:04 ` Greg Kroah-Hartman
2019-10-26 1:10 ` [RESEND PATCH 2/2] staging: rtl8712: Remove lines before a close brace Cristiane Naves
2019-10-26 18:05 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028080113.GD1944@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=cristianenavescardoso09@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome