From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3F1ECA9EBC for ; Mon, 28 Oct 2019 09:03:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91EE4208C0 for ; Mon, 28 Oct 2019 09:03:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387730AbfJ1JDj (ORCPT ); Mon, 28 Oct 2019 05:03:39 -0400 Received: from mx2.suse.de ([195.135.220.15]:50500 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730849AbfJ1JDj (ORCPT ); Mon, 28 Oct 2019 05:03:39 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 11EA8B04F; Mon, 28 Oct 2019 09:03:38 +0000 (UTC) Date: Mon, 28 Oct 2019 10:03:37 +0100 From: Daniel Wagner To: linux-scsi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "Martin K . Petersen" , Himanshu Madhani Subject: Re: [PATCH] scsi: qla2xxx: Check return value of alloc_workqueue() Message-ID: <20191028090337.i2n25yeuxw3rvacn@beryllium> References: <20191028084709.81538-1-dwagner@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191028084709.81538-1-dwagner@suse.de> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 28, 2019 at 09:47:09AM +0100, Daniel Wagner wrote: > Do not derefence the pointer without checking it > first. alloc_workqueue() can return a NULL pointer. Oh forget it. Someone was faster :)