From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
linux-sparse@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] compiler*.h: Add '__' prefix and suffix to all __attribute__ #defines
Date: Mon, 28 Oct 2019 23:15:24 +0100 [thread overview]
Message-ID: <20191028221523.vlzdk6dkcglxei6v@desk.local> (raw)
In-Reply-To: <19fd23e98bab65a1ee624445193bd2ed86108881.camel@perches.com>
On Mon, Oct 28, 2019 at 10:59:47AM -0700, Joe Perches wrote:
> On Mon, 2019-10-28 at 18:37 +0100, Miguel Ojeda wrote:
> > Just in case: for these ones (i.e. __CHECKER__), did you check if
> > sparse handles this syntax? (I don't recall myself if it does).
> >
> > Other than that, thanks for the cleanup too! I can pick it up in the
> > the compiler-attributes tree and put it in -next.
>
> Thanks for asking and no, I did not until just now.
> Turns out sparse does _not_ handle these changes and
> the checking fails for these __<changes>__.
>
> sparse would have to update parse.c or the __CHECKER__
> changes would need to be reverted.
>
> Perhaps update parse.c like:
...
Yes, this was missing. Thanks.
Can I have your SoB for this?
-- Luc
next prev parent reply other threads:[~2019-10-28 22:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 22:03 Joe Perches
2019-10-28 16:12 ` Nick Desaulniers
2019-10-28 17:37 ` Miguel Ojeda
2019-10-28 17:59 ` Joe Perches
2019-10-28 18:17 ` [PATCH V2] " Joe Perches
2019-10-28 22:15 ` Luc Van Oostenryck [this message]
2019-10-28 22:28 ` [PATCH] " Joe Perches
2019-10-28 23:03 ` Luc Van Oostenryck
2019-10-29 2:38 ` Ramsay Jones
2019-10-29 8:07 ` Luc Van Oostenryck
2019-10-29 18:54 ` Ramsay Jones
2019-10-30 9:38 ` kbuild test robot
2019-10-30 13:45 ` kbuild test robot
2019-10-30 16:29 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028221523.vlzdk6dkcglxei6v@desk.local \
--to=luc.vanoostenryck@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=clang-built-linux@googlegroups.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®