From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3277CA9EAE for ; Tue, 29 Oct 2019 18:06:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BFFB820862 for ; Tue, 29 Oct 2019 18:06:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730752AbfJ2SGT (ORCPT ); Tue, 29 Oct 2019 14:06:19 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:57756 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726594AbfJ2SGT (ORCPT ); Tue, 29 Oct 2019 14:06:19 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 2C95F14CFC095; Tue, 29 Oct 2019 11:06:18 -0700 (PDT) Date: Tue, 29 Oct 2019 11:06:17 -0700 (PDT) Message-Id: <20191029.110617.1405330302630427488.davem@davemloft.net> To: xiaojiangfeng@huawei.com Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, leeyou.li@huawei.com, zhanghan23@huawei.com, nixiaoming@huawei.com Subject: Re: [PATCH] net: hisilicon: Fix "Trying to free already-free IRQ" From: David Miller In-Reply-To: <1572011302-48605-1-git-send-email-xiaojiangfeng@huawei.com> References: <1572011302-48605-1-git-send-email-xiaojiangfeng@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 29 Oct 2019 11:06:18 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiangfeng Xiao Date: Fri, 25 Oct 2019 21:48:22 +0800 > When rmmod hip04_eth.ko, we can get the following warning: ... > Currently "rmmod hip04_eth.ko" call free_irq more than once > as devres_release_all and hip04_remove both call free_irq. > This results in a 'Trying to free already-free IRQ' warning. > To solve the problem free_irq has been moved out of hip04_remove. > > Signed-off-by: Jiangfeng Xiao Applied, thank you.