From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2254DCA9EC2 for ; Tue, 29 Oct 2019 08:06:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DD2172086A for ; Tue, 29 Oct 2019 08:06:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572336400; bh=A0tcD1zkhuDHdu3AWDJcL5XsJuzo5bpmTakxBWfkeGc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=0/sXehmKXDIwKB3nRyCwDxPAm8yfTvTDlXEosmxgEB6JVzZWtg5PPHxYZRdhgA3NA Pj0UcjwXv5sFTMoDheJtkygEkRBdN5gUtyWhe0qizYxQXc+jptnJw0FwfTnISARIQn J4j0TSytHSFFIYr2FtiGWLBDrLCMqS5KDJq8ECBo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728605AbfJ2IGi (ORCPT ); Tue, 29 Oct 2019 04:06:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:51708 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726246AbfJ2IGi (ORCPT ); Tue, 29 Oct 2019 04:06:38 -0400 Received: from localhost (unknown [91.217.168.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 28FDE20663; Tue, 29 Oct 2019 08:06:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572336397; bh=A0tcD1zkhuDHdu3AWDJcL5XsJuzo5bpmTakxBWfkeGc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UIko7I3wI8kuAH1op4qGk30onCjabcIebu6TGrY+DeHfRUQ9ALBsU/O2Kvxo/0XZf kvSbC2lSIKv+3iaJcjhAYPEd3DwQfWcsGmiWg1rJNu19VIbQTsnOYWF910qMAR5ug8 0pLKvGzKn4mneukFMgJyRVP07X8NmxsdjdrGebhY= Date: Tue, 29 Oct 2019 09:06:34 +0100 From: Greg KH To: zhong jiang Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: remove an redundant null check before kfree() Message-ID: <20191029080634.GB506924@kroah.com> References: <1571211506-19005-1-git-send-email-zhongjiang@huawei.com> <20191025024216.GB331827@kroah.com> <5DB711AE.1040904@huawei.com> <20191028162434.GB321492@kroah.com> <5DB794FB.4010203@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5DB794FB.4010203@huawei.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 29, 2019 at 09:25:15AM +0800, zhong jiang wrote: > On 2019/10/29 0:24, Greg KH wrote: > > On Tue, Oct 29, 2019 at 12:05:02AM +0800, zhong jiang wrote: > >> On 2019/10/25 10:42, Greg KH wrote: > >>> On Wed, Oct 16, 2019 at 03:38:26PM +0800, zhong jiang wrote: > >>>> kfree() has taken null pointer into account. hence it is safe to remove > >>>> the unnecessary check. > >>>> > >>>> Signed-off-by: zhong jiang > >>>> --- > >>>> drivers/staging/rtl8723bs/core/rtw_xmit.c | 3 +-- > >>>> 1 file changed, 1 insertion(+), 2 deletions(-) > >>>> > >>>> diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c > >>>> index 7011c2a..4597f4f 100644 > >>>> --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c > >>>> +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c > >>>> @@ -2210,8 +2210,7 @@ void rtw_free_hwxmits(struct adapter *padapter) > >>>> struct xmit_priv *pxmitpriv = &padapter->xmitpriv; > >>>> > >>>> hwxmits = pxmitpriv->hwxmits; > >>>> - if (hwxmits) > >>>> - kfree(hwxmits); > >>>> + kfree(hwxmits); > >>>> } > >>>> > >>>> void rtw_init_hwxmits(struct hw_xmit *phwxmit, sint entry) > >>>> -- > >>>> 1.7.12.4 > >>>> > >>> Patch does not apply to my tree :( > >>> > >>> . > >>> > >> Greg, Could you apply the patch to your tree ? > > It did not apply, so what do you want me to do with it? > > > > confused, > Could you receive the patch ? :-) The patch did not apply properly to my tree, there is no way I can apply it. Please fix it up and resend it so that I can apply it. thanks, greg k-h