From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A594CA9EAF for ; Wed, 30 Oct 2019 08:24:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68F9A2083E for ; Wed, 30 Oct 2019 08:24:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726417AbfJ3IY0 (ORCPT ); Wed, 30 Oct 2019 04:24:26 -0400 Received: from mga05.intel.com ([192.55.52.43]:9739 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725953AbfJ3IY0 (ORCPT ); Wed, 30 Oct 2019 04:24:26 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 01:24:25 -0700 X-IronPort-AV: E=Sophos;i="5.68,246,1569308400"; d="scan'208";a="193894229" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 01:24:21 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 50839208A0; Wed, 30 Oct 2019 10:24:21 +0200 (EET) Date: Wed, 30 Oct 2019 10:24:21 +0200 From: Sakari Ailus To: Dan Carpenter Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] media: smiapp: unlock on error in smiapp_start_streaming() Message-ID: <20191030082421.GE10211@paasikivi.fi.intel.com> References: <20191029182401.GB17569@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191029182401.GB17569@mwanda> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 29, 2019 at 09:24:01PM +0300, Dan Carpenter wrote: > We added two new error paths to smiapp_start_streaming(), but we can't > return directly without dropping the "sensor->mutex" lock. > > Fixes: f8c4352c1bef ("media: smiapp: Move binning configuration to streaming start") > Signed-off-by: Dan Carpenter Thanks, Dan! -- Sakari Ailus