From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26071CA9EC7 for ; Wed, 30 Oct 2019 11:54:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 065CE2080F for ; Wed, 30 Oct 2019 11:54:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726772AbfJ3LyS (ORCPT ); Wed, 30 Oct 2019 07:54:18 -0400 Received: from retiisi.org.uk ([95.216.213.190]:53126 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726065AbfJ3LyR (ORCPT ); Wed, 30 Oct 2019 07:54:17 -0400 Received: from valkosipuli.localdomain (valkosipuli.retiisi.org.uk [IPv6:2a01:4f9:c010:4572::80:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id D593F634C87; Wed, 30 Oct 2019 13:53:29 +0200 (EET) Received: from sailus by valkosipuli.localdomain with local (Exim 4.92) (envelope-from ) id 1iPmXY-0001eC-Sx; Wed, 30 Oct 2019 13:53:28 +0200 Date: Wed, 30 Oct 2019 13:53:28 +0200 From: Sakari Ailus To: Manivannan Sadhasivam Cc: mchehab@kernel.org, robh+dt@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, c.barrett@framos.com, a.brela@framos.com, peter.griffin@linaro.org Subject: Re: [PATCH v4 1/2] dt-bindings: media: i2c: Add IMX296 CMOS sensor binding Message-ID: <20191030115328.GA6253@valkosipuli.retiisi.org.uk> References: <20191030094902.32582-1-manivannan.sadhasivam@linaro.org> <20191030094902.32582-2-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191030094902.32582-2-manivannan.sadhasivam@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nabuvannan, On Wed, Oct 30, 2019 at 03:19:01PM +0530, Manivannan Sadhasivam wrote: > Add YAML devicetree binding for IMX296 CMOS image sensor. Let's also > add MAINTAINERS entry for the binding and driver. > > Signed-off-by: Manivannan Sadhasivam > --- > .../devicetree/bindings/media/i2c/imx296.yaml | 94 +++++++++++++++++++ > MAINTAINERS | 8 ++ > 2 files changed, 102 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx296.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx296.yaml b/Documentation/devicetree/bindings/media/i2c/imx296.yaml > new file mode 100644 > index 000000000000..c04ec2203268 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/imx296.yaml > @@ -0,0 +1,94 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/imx296.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sony IMX296 1/2.8-Inch CMOS Image Sensor > + > +maintainers: > + - Manivannan Sadhasivam > + > +description: |- > + The Sony IMX296 is a 1/2.9-Inch active pixel type CMOS Solid-state image > + sensor with square pixel array and 1.58 M effective pixels. This chip > + features a global shutter with variable charge-integration time. It is > + programmable through I2C and 4-wire interfaces. The sensor output is > + available via CSI-2 serial data output (1 Lane). > + > +properties: > + compatible: > + const: sony,imx296 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + description: > + Input clock for the sensor. > + items: > + - const: mclk > + > + clock-frequency: > + description: > + Frequency of the mclk clock in Hertz. > + > + vddo-supply: > + description: > + Definition of the regulator used as interface power supply. > + > + vdda-supply: > + description: > + Definition of the regulator used as analog power supply. > + > + vddd-supply: > + description: > + Definition of the regulator used as digital power supply. > + > + reset-gpios: > + description: > + The phandle and specifier for the GPIO that controls sensor reset. > + maxItems: 1 > + > + port: true You're missing "type: object" under port. -- Regards, Sakari Ailus