From: Vivien Didelot <vivien.didelot@gmail.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org
Subject: [PATCH net-next v2 7/7] net: dsa: tag_8021q: clarify index limitation
Date: Wed, 30 Oct 2019 22:09:19 -0400 [thread overview]
Message-ID: <20191031020919.139872-8-vivien.didelot@gmail.com> (raw)
In-Reply-To: <20191031020919.139872-1-vivien.didelot@gmail.com>
Now that there's no restriction from the DSA core side regarding
the switch IDs and port numbers, only tag_8021q which is currently
reserving 3 bits for the switch ID and 4 bits for the port number, has
limitation for these values. Update their descriptions to reflect that.
Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>
---
net/dsa/tag_8021q.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/dsa/tag_8021q.c b/net/dsa/tag_8021q.c
index bf91fc55fc44..bc5cb91bf052 100644
--- a/net/dsa/tag_8021q.c
+++ b/net/dsa/tag_8021q.c
@@ -31,15 +31,14 @@
* Must be transmitted as zero and ignored on receive.
*
* SWITCH_ID - VID[8:6]:
- * Index of switch within DSA tree. Must be between 0 and
- * DSA_MAX_SWITCHES - 1.
+ * Index of switch within DSA tree. Must be between 0 and 7.
*
* RSV - VID[5:4]:
* To be used for further expansion of PORT or for other purposes.
* Must be transmitted as zero and ignored on receive.
*
* PORT - VID[3:0]:
- * Index of switch port. Must be between 0 and DSA_MAX_PORTS - 1.
+ * Index of switch port. Must be between 0 and 15.
*/
#define DSA_8021Q_DIR_SHIFT 10
--
2.23.0
next prev parent reply other threads:[~2019-10-31 2:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 2:09 [PATCH net-next v2 0/7] net: dsa: replace routing tables with a list Vivien Didelot
2019-10-31 2:09 ` [PATCH net-next v2 1/7] net: dsa: list DSA links in the fabric Vivien Didelot
2019-10-31 2:09 ` [PATCH net-next v2 2/7] net: dsa: remove ds->rtable Vivien Didelot
2019-10-31 2:09 ` [PATCH net-next v2 3/7] net: dsa: remove switch routing table setup code Vivien Didelot
2019-10-31 2:09 ` [PATCH net-next v2 4/7] net: dsa: remove the dst->ds array Vivien Didelot
2019-10-31 2:09 ` [PATCH net-next v2 5/7] net: dsa: remove tree functions related to switches Vivien Didelot
2019-10-31 2:09 ` [PATCH net-next v2 6/7] net: dsa: remove limitation of switch index value Vivien Didelot
2019-10-31 2:09 ` Vivien Didelot [this message]
2019-10-31 21:47 ` [PATCH net-next v2 0/7] net: dsa: replace routing tables with a list David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031020919.139872-8-vivien.didelot@gmail.com \
--to=vivien.didelot@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®