From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B06FCA9ECF for ; Fri, 1 Nov 2019 07:57:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 62FEF2080F for ; Fri, 1 Nov 2019 07:57:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="WA+ly02R" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730065AbfKAH5j (ORCPT ); Fri, 1 Nov 2019 03:57:39 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:58988 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727059AbfKAH5j (ORCPT ); Fri, 1 Nov 2019 03:57:39 -0400 Received: from pendragon.ideasonboard.com (unknown [109.190.253.13]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5624D2D1; Fri, 1 Nov 2019 08:57:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1572595055; bh=DKSEd/4zmCFtM4D8ZLoAyFUzhEtzYdFH9A2SAZ6Kmsg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WA+ly02RQE1bXxx9ReIa6usD0bl1d0D1w+iCYgmRRvvUZpa3hkog3EbmOq8v5Ui1q 4JG9vZOadNUP3DwmdCtRMOUpIxAQP2R5HeFwf8vlq7xD+LeH/8tP9M/zIr/dWbcszb Pcd5Hz3IdhJhK6K4Ce+Cwr2E/vBruD5SNpzPX5SE= Date: Fri, 1 Nov 2019 09:57:26 +0200 From: Laurent Pinchart To: Adam Ford , Sam Ravnborg Cc: dri-devel , Linux-OMAP , Thierry Reding , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Sebastian Reichel , Tomi Valkeinen , devicetree , Linux Kernel Mailing List Subject: Re: [PATCH V5 1/3] drm/panel: simple: Add Logic PD Type 28 display support Message-ID: <20191101075726.GB6209@pendragon.ideasonboard.com> References: <20191016135147.7743-1-aford173@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 30, 2019 at 09:44:20AM -0500, Adam Ford wrote: > On Wed, Oct 16, 2019 at 8:52 AM Adam Ford wrote: > > > > Previously, there was an omap panel-dpi driver that would > > read generic timings from the device tree and set the display > > timing accordingly. This driver was removed so the screen > > no longer functions. This patch modifies the panel-simple > > file to setup the timings to the same values previously used. > > > > Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") > > Will this be able to make it into linux-next for the 5.5 merge window? > I believe Tony has picked up the device tree portion in his omap > tree, but I haven't seen any notifications on this series on whether > or not it's being applied. I also don't know which tree I need to > look if it's already been applied. > > This fixes a regression introduced a while ago where the driver I was > using for the display was removed. Sam, would you be able to pick this up ? > > Signed-off-by: Adam Ford > > Reviewed-by: Sam Ravnborg > > --- > > V5: No Change > > V4: No Change > > V3: No Change > > V2: No Change > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > > index 5d487686d25c..72f69709f349 100644 > > --- a/drivers/gpu/drm/panel/panel-simple.c > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > @@ -2061,6 +2061,40 @@ static const struct drm_display_mode mitsubishi_aa070mc01_mode = { > > .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, > > }; > > > > +static const struct drm_display_mode logicpd_type_28_mode = { > > + .clock = 9000, > > + .hdisplay = 480, > > + .hsync_start = 480 + 3, > > + .hsync_end = 480 + 3 + 42, > > + .htotal = 480 + 3 + 42 + 2, > > + > > + .vdisplay = 272, > > + .vsync_start = 272 + 2, > > + .vsync_end = 272 + 2 + 11, > > + .vtotal = 272 + 2 + 11 + 3, > > + .vrefresh = 60, > > + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC, > > +}; > > + > > +static const struct panel_desc logicpd_type_28 = { > > + .modes = &logicpd_type_28_mode, > > + .num_modes = 1, > > + .bpc = 8, > > + .size = { > > + .width = 105, > > + .height = 67, > > + }, > > + .delay = { > > + .prepare = 200, > > + .enable = 200, > > + .unprepare = 200, > > + .disable = 200, > > + }, > > + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, > > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE | > > + DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE, > > +}; > > + > > static const struct panel_desc mitsubishi_aa070mc01 = { > > .modes = &mitsubishi_aa070mc01_mode, > > .num_modes = 1, > > @@ -3287,6 +3321,9 @@ static const struct of_device_id platform_of_match[] = { > > }, { > > .compatible = "lg,lp129qe", > > .data = &lg_lp129qe, > > + }, { > > + .compatible = "logicpd,type28", > > + .data = &logicpd_type_28, > > }, { > > .compatible = "mitsubishi,aa070mc01-ca1", > > .data = &mitsubishi_aa070mc01, -- Regards, Laurent Pinchart