From: Feng Tang <feng.tang@intel.com>
To: Yang Shi <yang.shi@linux.alibaba.com>
Cc: "Chen, Rong A" <rong.a.chen@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.com>, Hugh Dickins <hughd@google.com>,
Shakeel Butt <shakeelb@google.com>,
David Rientjes <rientjes@google.com>, Qian Cai <cai@lca.pw>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>, "lkp@01.org" <lkp@01.org>
Subject: Re: [LKP] [mm] 87eaceb3fa: stress-ng.madvise.ops_per_sec -19.6% regression
Date: Sun, 3 Nov 2019 10:28:26 +0800 [thread overview]
Message-ID: <20191103022826.GA54034@shbuild999.sh.intel.com> (raw)
In-Reply-To: <23762632-2b5a-80fa-815f-1a8c58c5bb74@linux.alibaba.com>
On Sat, Nov 02, 2019 at 01:04:36AM +0800, Yang Shi wrote:
>
>
> On 11/1/19 2:41 AM, Feng Tang wrote:
> > Hi Yang,
> >
> > On Mon, Sep 30, 2019 at 04:46:05PM +0800, kernel test robot wrote:
> >> Greeting,
> >>
> >> FYI, we noticed a -19.6% regression of stress-ng.madvise.ops_per_sec due to commit:
> >>
> >>
> >> commit: 87eaceb3faa59b9b4d940ec9554ce251325d83fe ("mm: thp: make deferred split shrinker memcg aware")
> >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> >>
> >> in testcase: stress-ng
> >> on test machine: 72 threads Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz with 192G memory
> >> with following parameters:
> >>
> >> nr_threads: 100%
> >> disk: 1HDD
> >> testtime: 1s
> >> class: vm
> >> ucode: 0x200005e
> >> cpufreq_governor: performance
> >>
> >>
> >>
> >>
> >> If you fix the issue, kindly add following tag
> >> Reported-by: kernel test robot <rong.a.chen@intel.com>
> >>
> >>
> >> Details are as below:
> >> -------------------------------------------------------------------------------------------------->
> >>
> >>
> >> To reproduce:
> >>
> >> git clone https://github.com/intel/lkp-tests.git
> >> cd lkp-tests
> >> bin/lkp install job.yaml # job file is attached in this email
> >> bin/lkp run job.yaml
> >>
> >> =========================================================================================
> >> class/compiler/cpufreq_governor/disk/kconfig/nr_threads/rootfs/tbox_group/testcase/testtime/ucode:
> >> vm/gcc-7/performance/1HDD/x86_64-rhel-7.6/100%/debian-x86_64-2019-05-14.cgz/lkp-skl-2sp8/stress-ng/1s/0x200005e
> >>
> >> commit:
> >> 0a432dcbeb ("mm: shrinker: make shrinker not depend on memcg kmem")
> >> 87eaceb3fa ("mm: thp: make deferred split shrinker memcg aware")
> >>
> >> 0a432dcbeb32edcd 87eaceb3faa59b9b4d940ec9554
> >> ---------------- ---------------------------
> >> %stddev %change %stddev
> >> \ | \
> >> 6457 -19.5% 5198 stress-ng.madvise.ops
> >> 6409 -19.6% 5154 stress-ng.madvise.ops_per_sec
> > Do you have any clue on this?
>
> I replied the email once I got this report, please see
> https://lore.kernel.org/lkml/d30b1358-fb6b-2658-e675-ceff3bc465ab@linux.alibaba.com/
>
> And, the potential fix had been posted to the mailing list, please see
> https://lore.kernel.org/linux-mm/1569968203-64647-1-git-send-email-yang.shi@linux.alibaba.com/
>
> But, the review looks stalled, I will try to move it forward.
Great! Thanks for the update.
- Feng
>
> >
> > Thanks,
> > Feng
> >
prev parent reply other threads:[~2019-11-03 2:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 8:46 kernel test robot
2019-09-30 19:25 ` Yang Shi
2019-11-01 9:41 ` [LKP] " Feng Tang
2019-11-01 17:04 ` Yang Shi
2019-11-03 2:28 ` Feng Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191103022826.GA54034@shbuild999.sh.intel.com \
--to=feng.tang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=mhocko@suse.com \
--cc=rientjes@google.com \
--cc=rong.a.chen@intel.com \
--cc=shakeelb@google.com \
--cc=torvalds@linux-foundation.org \
--cc=vdavydov.dev@gmail.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome