From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88C7BCA9ED3 for ; Mon, 4 Nov 2019 12:47:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5539821D7D for ; Mon, 4 Nov 2019 12:47:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572871649; bh=nt6dnt0vrHAVTTEgsysOZfeWp8f9e5l14qQGlV5tTpU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=nJAIqRCxfKsLa52TYr8ckSqGqz2A415eNf9kHzTJE0PXPdS0QyLD5tmIH6XwDBnlJ eZ5fNobKn+sHSH5/QhB2yL5Kj9PSpEplXuJ5tio+UIIm2hR8Z5ZntOAd+9/vyairLo X1YHhl7IcTC3Wnbp+hNu7+tvfnRFlddxLwJQ7FsQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728973AbfKDMrX (ORCPT ); Mon, 4 Nov 2019 07:47:23 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:46862 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728396AbfKDMrX (ORCPT ); Mon, 4 Nov 2019 07:47:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=nQW/bkzEewczaxT+3uYr2EI926apxCfUzfvK6W9flNM=; b=eX9YNLdaHWXApFC5WH3YUJSoz duye5V5aJxyEa0X2sRrWdWgQsDTo4uhgIwg2UK8SaMVGp11RGSodOlIl07eRtejb2BzATT5SOEPtv lq9Hkne174NX0ErvZCPnbeJU5n9yGScoQnxfQfhkJYoxb2ct+DWNG8cLD4lKkgleLNPE4=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=ypsilon.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iRblP-0002Yo-Ij; Mon, 04 Nov 2019 12:47:19 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id F2AE1274301E; Mon, 4 Nov 2019 12:47:18 +0000 (GMT) Date: Mon, 4 Nov 2019 12:47:18 +0000 From: Mark Brown To: Palmer Dabbelt Cc: hslester96@gmail.com, Paul Walmsley , linux-spi@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] spi: sifive: disable clk when probe fails and remove Message-ID: <20191104124718.GC5238@sirena.co.uk> References: <20191101121745.13413-1-hslester96@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="96YOpH+ONegL0A3E" Content-Disposition: inline In-Reply-To: X-Cookie: This page intentionally left blank. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --96YOpH+ONegL0A3E Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 01, 2019 at 04:07:29PM -0700, Palmer Dabbelt wrote: > On Fri, 01 Nov 2019 05:17:45 PDT (-0700), hslester96@gmail.com wrote: > > The driver forgets to disable and unprepare clk when probe fails and > > remove. > > Add the calls to fix the problem. > Reviewed-by: Palmer Dabbelt Please delete unneeded context from mails when replying. Doing this makes it much easier to find your reply in the message, helping ensure it won't be missed by people scrolling through the irrelevant quoted material. --96YOpH+ONegL0A3E Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl3AHdYACgkQJNaLcl1U h9Bxbwf+PS/3tt1r3nRdDUeTgiw12asFTlFdosGPaCdJ0zCp0XBMPgFZBia9R16z QBrOHOQ5BL+W7FEEOh9hfPpvdVPzgygwAip2n2uHEWrOZ7pt7PWoGj2ybu0JDXTu rPhwWNvY36hCVKElOiixQeR43pU7yKJZzPoWVTxJgGarWaE03ngE0jEvQUqtsVMB aI0LNK076Dt9geC7wg5FFSppQTVv6c9PvpTehaS5hKvY00hfUS3i9uFgYsXjuggz TYsKknIrHD0gm0Q1bCfGK7u6C3YkbyPs6uj1j2xZLh5isMgVokBkrlpkbpMtKl+i PPxqmUKox9ymgSDfmnZ1yGneuS3qVg== =2j2y -----END PGP SIGNATURE----- --96YOpH+ONegL0A3E--