mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH 2/5] clocksource/drivers/timer-of: Use unique device name instead of timer
Date: Mon,  4 Nov 2019 15:22:54 +0100	[thread overview]
Message-ID: <20191104142257.30029-2-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <20191104142257.30029-1-daniel.lezcano@linaro.org>

From: Geert Uytterhoeven <geert+renesas@glider.be>

If a hardware-specific driver does not provide a name, the timer-of core
falls back to device_node.name.  Due to generic DT node naming policies,
that name is almost always "timer", and thus doesn't identify the actual
timer used.

Fix this by using device_node.full_name instead, which includes the unit
addrees.

Example impact on /proc/timer_list:

    -Clock Event Device: timer
    +Clock Event Device: timer@fcfec400

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20191016144747.29538-3-geert+renesas@glider.be
---
 drivers/clocksource/timer-of.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-of.c b/drivers/clocksource/timer-of.c
index 384394205a12..8c11bd743dd0 100644
--- a/drivers/clocksource/timer-of.c
+++ b/drivers/clocksource/timer-of.c
@@ -190,7 +190,7 @@ int __init timer_of_init(struct device_node *np, struct timer_of *to)
 	}
 
 	if (!to->clkevt.name)
-		to->clkevt.name = np->name;
+		to->clkevt.name = np->full_name;
 
 	to->np = np;
 
-- 
2.17.1


  reply	other threads:[~2019-11-04 14:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-04 14:21 [GIT PULL] clockevents for 5.6 Daniel Lezcano
2019-11-04 14:22 ` [PATCH 1/5] clocksource/drivers/timer-of: Convert last full_name to %pOF Daniel Lezcano
2019-11-04 14:22   ` Daniel Lezcano [this message]
2019-11-04 14:22   ` [PATCH 3/5] clocksource/drivers/renesas-ostm: Convert to timer_of Daniel Lezcano
2019-11-04 14:22   ` [PATCH 4/5] clocksource/drivers/renesas-ostm: Use unique device name instead of ostm Daniel Lezcano
2019-11-04 14:22   ` [PATCH 5/5] clocksource/drivers/asm9260: Add a check for of_clk_get Daniel Lezcano
2019-11-04 17:48 ` [GIT PULL] clockevents for 5.6 Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191104142257.30029-2-daniel.lezcano@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=geert+renesas@glider.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®