From: Alyssa Ross <hi@alyssa.is>
To: linux-kbuild@vger.kernel.org
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-kernel@vger.kernel.org, Alyssa Ross <hi@alyssa.is>
Subject: [PATCH] kconfig: be more helpful if pkg-config is missing
Date: Mon, 4 Nov 2019 20:44:54 +0000 [thread overview]
Message-ID: <20191104204453.20115-1-hi@alyssa.is> (raw)
If ncurses is installed, but at a non-default location, the previous
error message was not helpful in resolving the situation. Now, if
ncurses can't be found, and pkg-config is not installed, it will
suggest that pkg-config might need to be installed in addition to
ncurses.
Signed-off-by: Alyssa Ross <hi@alyssa.is>
---
scripts/kconfig/mconf-cfg.sh | 14 ++++++++++++--
scripts/kconfig/nconf-cfg.sh | 14 ++++++++++++--
2 files changed, 24 insertions(+), 4 deletions(-)
diff --git a/scripts/kconfig/mconf-cfg.sh b/scripts/kconfig/mconf-cfg.sh
index c812872d7f9d..f547b13f77f6 100755
--- a/scripts/kconfig/mconf-cfg.sh
+++ b/scripts/kconfig/mconf-cfg.sh
@@ -41,7 +41,17 @@ fi
echo >&2 "*"
echo >&2 "* Unable to find the ncurses package."
-echo >&2 "* Install ncurses (ncurses-devel or libncurses-dev"
-echo >&2 "* depending on your distribution)."
+echo >&2 "*"
+if [ -n "$(command -v pkg-config)" ]; then
+ echo >&2 "* Install ncurses (ncurses-devel or libncurses-dev"
+ echo >&2 "* depending on your distribution)."
+else
+ echo >&2 "* You may need to install ncurses"
+ echo >&2 "* (ncurses-devel or libncurses-dev"
+ echo >&2 "* depending on your distribution)."
+ echo >&2 "*"
+ echo >&2 "* If you have ncurses installed,"
+ echo >&2 "* you may also need to install pkg-config."
+fi
echo >&2 "*"
exit 1
diff --git a/scripts/kconfig/nconf-cfg.sh b/scripts/kconfig/nconf-cfg.sh
index 001559ef0a60..569226f1b497 100755
--- a/scripts/kconfig/nconf-cfg.sh
+++ b/scripts/kconfig/nconf-cfg.sh
@@ -41,7 +41,17 @@ fi
echo >&2 "*"
echo >&2 "* Unable to find the ncurses package."
-echo >&2 "* Install ncurses (ncurses-devel or libncurses-dev"
-echo >&2 "* depending on your distribution)."
+echo >&2 "*"
+if [ -n "$(command -v pkg-config)" ]; then
+ echo >&2 "* Install ncurses (ncurses-devel or libncurses-dev"
+ echo >&2 "* depending on your distribution)."
+else
+ echo >&2 "* You may need to install ncurses"
+ echo >&2 "* (ncurses-devel or libncurses-dev"
+ echo >&2 "* depending on your distribution)."
+ echo >&2 "*"
+ echo >&2 "* If you have ncurses installed,"
+ echo >&2 "* you may also need to install pkg-config."
+fi
echo >&2 "*"
exit 1
--
2.23.0
next reply other threads:[~2019-11-04 20:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 20:44 Alyssa Ross [this message]
2019-11-05 4:28 ` Masahiro Yamada
2019-11-05 15:04 ` [PATCH v2] " Alyssa Ross
2019-11-05 15:07 ` [PATCH v3] " Alyssa Ross
2019-11-06 2:17 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104204453.20115-1-hi@alyssa.is \
--to=hi@alyssa.is \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®