mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Michael Petlan <mpetlan@redhat.com>
Subject: Re: [PATCH] perf tools: Fix time sorting
Date: Tue, 5 Nov 2019 08:49:41 -0300	[thread overview]
Message-ID: <20191105114941.GA4218@kernel.org> (raw)
In-Reply-To: <20191105004854.GA25308@tassilo.jf.intel.com>

Em Mon, Nov 04, 2019 at 04:48:54PM -0800, Andi Kleen escreveu:
> On Tue, Nov 05, 2019 at 12:27:11AM +0100, Jiri Olsa wrote:
> > The final sort might get confused when the comparison
> > is done over bigger numbers than int like for -s time.
> > 
> > Check following report for longer workloads:
> >   $ perf report -s time -F time,overhead --stdio
> > 
> > Fixing hist_entry__sort to properly return int64_t and
> > not possible cut int.
> > 
> > Cc: Andi Kleen <ak@linux.intel.com>
> > Link: http://lkml.kernel.org/n/tip-uetl5z1eszpubzqykvdftaq6@git.kernel.org
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> 
> Looks good.
> 
> Reviewed-by: Andi Kleen <ak@linux.intel.com>

Thanks, applied after adding:

Fixes: 043ca389a318 ("perf tools: Use hpp formats to sort final output")
Cc: stable@vger.kernel.org # v3.16+

- Arnaldo

  reply	other threads:[~2019-11-05 11:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-04 23:27 Jiri Olsa
2019-11-05  0:48 ` Andi Kleen
2019-11-05 11:49   ` Arnaldo Carvalho de Melo [this message]
2019-11-05 12:41     ` Jiri Olsa
2019-11-05 13:22       ` Arnaldo Carvalho de Melo
2019-11-06 18:14 ` [tip: perf/urgent] " tip-bot2 for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191105114941.GA4218@kernel.org \
    --to=arnaldo.melo@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mpetlan@redhat.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome