From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC15DC5DF60 for ; Tue, 5 Nov 2019 22:27:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7DD89204EC for ; Tue, 5 Nov 2019 22:27:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="LFfLw+MB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730491AbfKEW1J (ORCPT ); Tue, 5 Nov 2019 17:27:09 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:35956 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730445AbfKEW1H (ORCPT ); Tue, 5 Nov 2019 17:27:07 -0500 Received: by mail-pg1-f193.google.com with SMTP id k13so4257353pgh.3 for ; Tue, 05 Nov 2019 14:27:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xXg/NZjH/hD7TX6jGqJIEb/eBe/oXUCzE/oQZad6cbA=; b=LFfLw+MBKreN1Iof4xXyoEYjmtrVkMT0JjgV7qXaDAW5UICiCD8RRjQpU8T/boKuPX LdsecS1zbVezUfZs8hg0Et+d6l6pRX65Udig3mGmFDgmg2iRnssTxG4FR0sEsJcUjz1w C3MPcrGWVsKZsMXC1MDm2QgpOU466o+NxGzwU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xXg/NZjH/hD7TX6jGqJIEb/eBe/oXUCzE/oQZad6cbA=; b=IOKvopR14168nbMOpcDQIaABm3VA0iP3k9PqZWYJt6EaqX6YODf7GsurTlsLMKGsqS +Eb0NFhQglsp05WfReSar4fXELq9IyZj8S96fKMML1V1harOx+xKvCp9uHKqFW28Kk1w i+s20MFEy//wDHVO5DFCjAdvsVo6TaPNPHoPTdCmX1Ifdt0MqFCD1wwnrUdrTI9n+Pfy t4B0zlFqTPyeOY+Ui0nHz/t2zkIcQORT1we/8vzzxUPBGXDwoR2XPobALUa/dQ2+qv94 d1PxP7bc/1qVX0xh8d4iqpNcogs8y3hO09CC2hLLTh5HAyw+DzBlaMVNycqMH8hDogzq ndKw== X-Gm-Message-State: APjAAAUz5fkcqAGbQneJSus9aUCRw1SBdHfx2EzK36jpXeHNVdv6qWw9 e83OuQbKfHugAJgQSLNs7HQANQ== X-Google-Smtp-Source: APXvYqwsu6CpMgRQEtw0FjUj56O/BjNVUox2OHY+SuYH5Kjpvitqm7JjoNSHEgbpdxdoGQRMuzsUhQ== X-Received: by 2002:a62:1ac6:: with SMTP id a189mr40204637pfa.96.1572992826306; Tue, 05 Nov 2019 14:27:06 -0800 (PST) Received: from localhost ([2620:15c:202:1:3c8f:512b:3522:dfaf]) by smtp.gmail.com with ESMTPSA id d9sm20415695pgc.80.2019.11.05.14.27.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Nov 2019 14:27:05 -0800 (PST) From: Gwendal Grignou To: briannorris@chromium.org, jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, lee.jones@linaro.org, bleung@chromium.org, enric.balletbo@collabora.com, dianders@chromium.org, groeck@chromium.org, fabien.lahoudere@collabora.com Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Gwendal Grignou , Enrico Granata Subject: [PATCH v4 05/17] platform: chrome: cros_ec: Do not attempt to register a non-positive IRQ number Date: Tue, 5 Nov 2019 14:26:40 -0800 Message-Id: <20191105222652.70226-6-gwendal@chromium.org> X-Mailer: git-send-email 2.24.0.rc1.363.gb1bccd3e3d-goog In-Reply-To: <20191105222652.70226-1-gwendal@chromium.org> References: <20191105222652.70226-1-gwendal@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a layer of sanity checking to cros_ec_register against attempting to register IRQ values that are not strictly greater than 0. Signed-off-by: Enrico Granata Signed-off-by: Gwendal Grignou --- No changes in v4, v3. Changes in v2: Remove dual Enrico's signature. drivers/platform/chrome/cros_ec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c index 925f84dbf621..d3dfa27171e6 100644 --- a/drivers/platform/chrome/cros_ec.c +++ b/drivers/platform/chrome/cros_ec.c @@ -149,7 +149,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev) return err; } - if (ec_dev->irq) { + if (ec_dev->irq > 0) { err = devm_request_threaded_irq(dev, ec_dev->irq, ec_irq_handler, ec_irq_thread, -- 2.24.0.rc1.363.gb1bccd3e3d-goog