From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42099C5DF60 for ; Tue, 5 Nov 2019 23:51:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D669321A49 for ; Tue, 5 Nov 2019 23:51:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572997895; bh=4bojycx5BDgIwZi8sfx6zfyyIqLY78zT0BAEFLQoRm8=; h=From:To:Cc:Subject:In-Reply-To:Date:List-ID:From; b=ExrLjUBpshcI+Zc1kUIooHW6ilyGDQqF/u/ftkCD8AGEdJ1VxqPh46hp8ML1n9m9U zvil+QEuiFMAOYDVkSLofNIJIkU3wMkHpSnUy6H+42LuvVCeJhbi5BWBSftT8hE88k gcuBTXTjgHdg8xXzzoyPhuWXqmjtD8JlwDu/Jqcc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730459AbfKEXve (ORCPT ); Tue, 5 Nov 2019 18:51:34 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:54166 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730244AbfKEXve (ORCPT ); Tue, 5 Nov 2019 18:51:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=r6tFQqfrm0yNOWZRc+wvUJtnhu3em+Se6P8bMmjwxCw=; b=DwhLrfI0SXYp 12JD7mqLbOTjW226kjH5+XfHMtFlowqKUKgjzU0c4NTEAHkui9sAqVeYC5a/ksdXGTMDj0eZ/gyGC Vu3I6YvqtcgP4qgJGvr7Cr1sQtfVNil7YpMYjUFrPccZpEjK5OszFt/1wPvPyBTeiahKM7oPO1HMI YTUfE=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=ypsilon.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iS8bi-00083A-B3; Tue, 05 Nov 2019 23:51:30 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id CEADC274301E; Tue, 5 Nov 2019 23:51:29 +0000 (GMT) From: Mark Brown To: Thor Thayer Cc: broonie@kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mark Brown Subject: Applied "spi: dw: Fix Designware SPI loopback" to the spi tree In-Reply-To: <1572985330-5525-1-git-send-email-thor.thayer@linux.intel.com> X-Patchwork-Hint: ignore Message-Id: <20191105235129.CEADC274301E@ypsilon.sirena.org.uk> Date: Tue, 5 Nov 2019 23:51:29 +0000 (GMT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch spi: dw: Fix Designware SPI loopback has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.4 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 1403cfa69d310781f9548951c97725c67ffcf613 Mon Sep 17 00:00:00 2001 From: Thor Thayer Date: Tue, 5 Nov 2019 14:22:10 -0600 Subject: [PATCH] spi: dw: Fix Designware SPI loopback The SPI_LOOP is set in spi->mode but not propagated to the register. A previous patch removed the bit during a cleanup. Fixes: e1bc204894ea ("spi: dw: fix potential variable assignment error") Signed-off-by: Thor Thayer Link: https://lore.kernel.org/r/1572985330-5525-1-git-send-email-thor.thayer@linux.intel.com Signed-off-by: Mark Brown --- drivers/spi/spi-dw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c index 9a49e073e8b7..076652d3d051 100644 --- a/drivers/spi/spi-dw.c +++ b/drivers/spi/spi-dw.c @@ -308,7 +308,8 @@ static int dw_spi_transfer_one(struct spi_controller *master, cr0 = (transfer->bits_per_word - 1) | (chip->type << SPI_FRF_OFFSET) | ((((spi->mode & SPI_CPOL) ? 1 : 0) << SPI_SCOL_OFFSET) | - (((spi->mode & SPI_CPHA) ? 1 : 0) << SPI_SCPH_OFFSET)) + (((spi->mode & SPI_CPHA) ? 1 : 0) << SPI_SCPH_OFFSET) | + (((spi->mode & SPI_LOOP) ? 1 : 0) << SPI_SRL_OFFSET)) | (chip->tmode << SPI_TMOD_OFFSET); /* -- 2.20.1