From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECA06C5DF61 for ; Thu, 7 Nov 2019 05:47:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1CC9214D8 for ; Thu, 7 Nov 2019 05:47:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727025AbfKGFro (ORCPT ); Thu, 7 Nov 2019 00:47:44 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:34254 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725763AbfKGFro (ORCPT ); Thu, 7 Nov 2019 00:47:44 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D57211513A138; Wed, 6 Nov 2019 21:47:43 -0800 (PST) Date: Wed, 06 Nov 2019 21:47:43 -0800 (PST) Message-Id: <20191106.214743.227020197538874041.davem@davemloft.net> To: tanhuazhong@huawei.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, salil.mehta@huawei.com, yisen.zhuang@huawei.com, linuxarm@huawei.com, jakub.kicinski@netronome.com Subject: Re: [PATCH net] net: hns3: add compatible handling for command HCLGE_OPC_PF_RST_DONE From: David Miller In-Reply-To: <1573090219-9785-1-git-send-email-tanhuazhong@huawei.com> References: <1573090219-9785-1-git-send-email-tanhuazhong@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 06 Nov 2019 21:47:44 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Huazhong Tan Date: Thu, 7 Nov 2019 09:30:19 +0800 > Since old firmware does not support HCLGE_OPC_PF_RST_DONE, it will > return -EOPNOTSUPP to the driver when received this command. So > for this case, it should just print a warning and return success > to the caller. > > Fixes: 72e2fb07997c ("net: hns3: clear reset interrupt status in hclge_irq_handle()") > Signed-off-by: Huazhong Tan Applied, thanks.