From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 077EDC5DF62 for ; Wed, 6 Nov 2019 03:07:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7BEF222CF for ; Wed, 6 Nov 2019 03:07:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b="fdbYtnnr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387795AbfKFDHO (ORCPT ); Tue, 5 Nov 2019 22:07:14 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:43656 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387779AbfKFDHN (ORCPT ); Tue, 5 Nov 2019 22:07:13 -0500 Received: by mail-pf1-f196.google.com with SMTP id 3so17715281pfb.10 for ; Tue, 05 Nov 2019 19:07:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=googlenew; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dpUGho02FroZqV6HXW0Qyb5qfjXUEDBHxzb8cp33DnY=; b=fdbYtnnrlqBVQPRWvemv5Sot7Idqj4/QKXAvf57L3HbRJZtw4S70u30fc5FPW/Q6BC iQ7oEoc7IsRToDIr0FiSmqr5esRWV1N5eqSa+ryOh7MUly4D2P3l+NSW39jHVfzzeodz xm3PHLfJByqqhTfEDFrnDg6OxkiCwwXSvHVtuxxoW/vZ7q+IpVHvln6/WcRle2E6iAeY IY7xOR3YudSYnDkTGrbNCrVaeudqrtpiJx/bjJdwmMm8W95MjbdL8eTDSX/+eEXrJ1Pl dExWt8NYfjNpd+CaqTnoitgga4vIWd8kIlSfoqEGu51LwPGVKQNBDyf1YFQqSdaepKm1 PoSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dpUGho02FroZqV6HXW0Qyb5qfjXUEDBHxzb8cp33DnY=; b=GT37IBVq34tGWm3NXZKz8HyDaEe8/t+JWteH3Pu/URsFxYbFMXTsCTh5lFf9Kblno1 fm2wjG++39jG7aVQL1a1kCK6hqs5SO2m/zSnegAbZqbdy/B5smmdXcvcpoi/o40IiyfR FwzL0z5uZh9uTRanu4ZO5zQq5ctYqlUiYvx7Li6V5VrGhgkbP1y+hlAR/oddXrK7lYFd IHIgb1kucZZ1NMP//GCQQnlIk13RTfbZqY0V2USIvyls4cuSRhoI+rSousccrdAbMIwd 8p8dSClODAvFTmGWYFrgNl3QCJ+oxItYS0yvIx4hl7x4vgYBaShq/cWdxh8lxOGe0d8O Vz1w== X-Gm-Message-State: APjAAAXpSoIjz78cK6ITFQNPi551aXg4yf2ixhoTRhA5NE6ilvFmNnYZ drxSI91ZfIivRu942kWcDon79H3RLBA= X-Google-Smtp-Source: APXvYqxNiBWvjDDGSYHXNdKN4fxI7jr6zUOAdZ23F0mAGwWRFARdYeTBYcOy6LClQ8Kmqqw0pChmLQ== X-Received: by 2002:a63:d405:: with SMTP id a5mr184786pgh.79.1573009632450; Tue, 05 Nov 2019 19:07:12 -0800 (PST) Received: from Mindolluin.ire.aristanetworks.com ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id k24sm19570487pgl.6.2019.11.05.19.07.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 19:07:11 -0800 (PST) From: Dmitry Safonov To: linux-kernel@vger.kernel.org Cc: Dmitry Safonov <0x7f454c46@gmail.com>, Dmitry Safonov , Andrew Morton , Greg Kroah-Hartman , Ingo Molnar , Jiri Slaby , Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Tetsuo Handa , Fenghua Yu , Tony Luck , linux-ia64@vger.kernel.org Subject: [PATCH 16/50] ia64: Add show_stack_loglvl() Date: Wed, 6 Nov 2019 03:05:07 +0000 Message-Id: <20191106030542.868541-17-dima@arista.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191106030542.868541-1-dima@arista.com> References: <20191106030542.868541-1-dima@arista.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently, the log-level of show_stack() depends on a platform realization. It creates situations where the headers are printed with lower log level or higher than the stacktrace (depending on a platform or user). Furthermore, it forces the logic decision from user to an architecture side. In result, some users as sysrq/kdb/etc are doing tricks with temporary rising console_loglevel while printing their messages. And in result it not only may print unwanted messages from other CPUs, but also omit printing at all in the unlucky case where the printk() was deferred. Introducing log-level parameter and KERN_UNSUPPRESSED [1] seems an easier approach than introducing more printk buffers. Also, it will consolidate printings with headers. Introduce show_stack_loglvl(), that eventually will substitute show_stack(). Cc: Fenghua Yu Cc: Tony Luck Cc: linux-ia64@vger.kernel.org [1]: https://lore.kernel.org/lkml/20190528002412.1625-1-dima@arista.com/T/#u Signed-off-by: Dmitry Safonov --- arch/ia64/kernel/process.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/arch/ia64/kernel/process.c b/arch/ia64/kernel/process.c index 0526cc51ff0b..b0eeb19bdd8d 100644 --- a/arch/ia64/kernel/process.c +++ b/arch/ia64/kernel/process.c @@ -85,18 +85,25 @@ ia64_do_show_stack (struct unw_frame_info *info, void *arg) } void -show_stack (struct task_struct *task, unsigned long *sp) +show_stack_loglvl (struct task_struct *task, unsigned long *sp, + const char *loglvl) { if (!task) - unw_init_running(ia64_do_show_stack, (void *)KERN_DEFAULT); + unw_init_running(ia64_do_show_stack, (void *)loglvl); else { struct unw_frame_info info; unw_init_from_blocked_task(&info, task); - ia64_do_show_stack(&info, (void *)KERN_DEFAULT); + ia64_do_show_stack(&info, (void *)loglvl); } } +void +show_stack (struct task_struct *task, unsigned long *sp) +{ + show_stack_loglvl(task, sp, KERN_DEFAULT); +} + void show_regs (struct pt_regs *regs) { -- 2.23.0