From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Jonas Bonn <jonas@norrbonn.se>
Cc: nicolas.dichtel@6wind.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH v2 1/5] rtnetlink: allow RTM_SETLINK to reference other namespaces
Date: Wed, 6 Nov 2019 18:38:48 -0500 [thread overview]
Message-ID: <20191106183848.3b914620@cakuba.netronome.com> (raw)
In-Reply-To: <20191106053923.10414-2-jonas@norrbonn.se>
On Wed, 6 Nov 2019 06:39:19 +0100, Jonas Bonn wrote:
> + if (tb[IFLA_TARGET_NETNSID]) {
> + int32_t netnsid = nla_get_s32(tb[IFLA_TARGET_NETNSID]);
> + tgt_net = rtnl_get_net_ns_capable(NETLINK_CB(skb).sk, netnsid);
No comments on merits but you should definitely run this through
checkpatch..
next prev parent reply other threads:[~2019-11-06 23:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 5:39 [PATCH v2 0/5] Add namespace awareness to Netlink methods Jonas Bonn
2019-11-06 5:39 ` [PATCH v2 1/5] rtnetlink: allow RTM_SETLINK to reference other namespaces Jonas Bonn
2019-11-06 23:38 ` Jakub Kicinski [this message]
2019-11-06 5:39 ` [PATCH v2 2/5] rtnetlink: skip namespace change if already effect Jonas Bonn
2019-11-06 5:39 ` [PATCH v2 3/5] rtnetlink: allow RTM_NEWLINK to act upon interfaces in arbitrary namespaces Jonas Bonn
2019-11-06 5:39 ` [PATCH v2 4/5] net: ipv4: allow setting address on interface outside current namespace Jonas Bonn
2019-11-06 21:06 ` Nicolas Dichtel
2019-11-06 5:39 ` [PATCH v2 5/5] net: namespace: allow setting NSIDs " Jonas Bonn
2019-11-06 22:12 ` [PATCH v2 0/5] Add namespace awareness to Netlink methods David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106183848.3b914620@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=jonas@norrbonn.se \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®