From: Peter Zijlstra <peterz@infradead.org>
To: "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk>
Cc: linux-kernel@lists.codethink.co.uk,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf/core: fix missing static inline on perf_cgroup_switch
Date: Thu, 7 Nov 2019 09:44:04 +0100 [thread overview]
Message-ID: <20191107084404.GY4131@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20191106132527.19977-1-ben.dooks@codethink.co.uk>
On Wed, Nov 06, 2019 at 01:25:27PM +0000, Ben Dooks (Codethink) wrote:
> It looks like a "static inline" has been missed in front
> of the empty definition of perf_cgroup_switch under
> certain configurations. Fixes the following sparse warning:
>
> kernel/events/core.c:1035:1: warning: symbol 'perf_cgroup_switch' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
Thanks!
next prev parent reply other threads:[~2019-11-07 8:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 13:25 Ben Dooks (Codethink)
2019-11-06 14:50 ` Mark Rutland
2019-11-07 8:44 ` Peter Zijlstra [this message]
2019-11-13 10:06 ` [tip: perf/urgent] perf/core: Fix missing static inline on perf_cgroup_switch() tip-bot2 for Ben Dooks (Codethink)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107084404.GY4131@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=ben.dooks@codethink.co.uk \
--cc=jolsa@redhat.com \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®