From: David Miller <davem@davemloft.net>
To: mschiffer@universe-factory.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com
Subject: Re: [PATCH net-next 2/2] bridge: implement get_link_ksettings ethtool method
Date: Mon, 11 Nov 2019 14:41:43 -0800 (PST) [thread overview]
Message-ID: <20191111.144143.1922066976980512193.davem@davemloft.net> (raw)
In-Reply-To: <8e414e98928aba7f11ea997498fb18af05434f5f.1573321597.git.mschiffer@universe-factory.net>
From: Matthias Schiffer <mschiffer@universe-factory.net>
Date: Sat, 9 Nov 2019 18:54:14 +0100
> + if (cmd->base.speed == (__u32)SPEED_UNKNOWN ||
> + cmd->base.speed < ecmd.base.speed) {
> + cmd->base.speed = ecmd.base.speed;
> + }
Curly braces are unnecessary for single line statements, so please remove.
prev parent reply other threads:[~2019-11-12 20:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-09 17:54 [PATCH net-next 0/2] Implement get_link_ksettings for VXLAN and bridge Matthias Schiffer
2019-11-09 17:54 ` [PATCH net-next 1/2] vxlan: implement get_link_ksettings ethtool method Matthias Schiffer
2019-11-09 17:54 ` [PATCH net-next 2/2] bridge: " Matthias Schiffer
2019-11-11 22:15 ` Nikolay Aleksandrov
2019-11-11 22:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111.144143.1922066976980512193.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mschiffer@universe-factory.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®