From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=DATE_IN_PAST_12_24, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BA34C43331 for ; Tue, 12 Nov 2019 20:12:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BEEA2067B for ; Tue, 12 Nov 2019 20:12:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727178AbfKLUMW (ORCPT ); Tue, 12 Nov 2019 15:12:22 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:48938 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726957AbfKLUMJ (ORCPT ); Tue, 12 Nov 2019 15:12:09 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D1376154D250F; Tue, 12 Nov 2019 12:12:08 -0800 (PST) Date: Mon, 11 Nov 2019 15:14:35 -0800 (PST) Message-Id: <20191111.151435.931035548376130641.davem@davemloft.net> To: clabbe@baylibre.com Cc: alexandre.torgue@st.com, joabreu@synopsys.com, mripard@kernel.org, peppe.cavallaro@st.com, wens@csie.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-sunxi@googlegroups.com, stable@vger.kernel.org Subject: Re: [PATCH] net: ethernet: dwmac-sun8i: Use the correct function in exit path From: David Miller In-Reply-To: <1573385448-30282-1-git-send-email-clabbe@baylibre.com> References: <1573385448-30282-1-git-send-email-clabbe@baylibre.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 12 Nov 2019 12:12:09 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Corentin Labbe Date: Sun, 10 Nov 2019 11:30:48 +0000 > When PHY is not powered, the probe function fail and some resource are > still unallocated. > Furthermore some BUG happens: > dwmac-sun8i 5020000.ethernet: EMAC reset timeout > ------------[ cut here ]------------ > kernel BUG at /linux-next/net/core/dev.c:9844! > > So let's use the right function (stmmac_pltfr_remove) in the error path. > > Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i") > Cc: # v4.15+ > Signed-off-by: Corentin Labbe Applied.