From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8609C43331 for ; Mon, 11 Nov 2019 08:57:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 97F892084F for ; Mon, 11 Nov 2019 08:57:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573462671; bh=Vrp5/ERwffq29pFSSGEvCIFxpZJPJVSS8eCwpNf9IhM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=HrN5w5HN9SjhAoZ+L9JGCmvEkWHMEPgT1ErR8l8zGMXmmr+Px9b82d81M25bdHkip 1nMHPSbs9miUmd18ITMOTUdAt3IW6qupggAXFEiDTinA595CtXQoxuvJhIL6NXm4T6 pITn1+Lhm1kvqClaNMKEqoeuuuCaOqgxe9O0g5ZQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726932AbfKKI5u (ORCPT ); Mon, 11 Nov 2019 03:57:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:42098 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726768AbfKKI5u (ORCPT ); Mon, 11 Nov 2019 03:57:50 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D7E42206BA; Mon, 11 Nov 2019 08:57:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573462669; bh=Vrp5/ERwffq29pFSSGEvCIFxpZJPJVSS8eCwpNf9IhM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lHefqC1271fP5BS70SJE2Ei4v7XUmuv5aPWFTD2di0Mf4MKevHk8yWIAcb5kb+JuD CGOeMMgDKP5ajMEu/oxhPcV+gQdV2k9xijPkEm5ncKoVD7MTvGrXp7wncIDfKXEDT7 ACw8b0SPsWnD12a0ukhmfsWW/s9IfWF/3Pi4Xaks= Date: Mon, 11 Nov 2019 09:57:46 +0100 From: Greg KH To: Takashi Iwai Cc: syzbot , allison@lohutok.net, alsa-devel@alsa-project.org, benquike@gmail.com, dan.carpenter@oracle.com, glider@google.com, linux-kernel@vger.kernel.org, perex@perex.cz, syzkaller-bugs@googlegroups.com, tglx@linutronix.de, tiwai@suse.com, wang6495@umn.edu, yuehaibing@huawei.com Subject: Re: KMSAN: uninit-value in get_term_name Message-ID: <20191111085746.GA3994938@kroah.com> References: <000000000000f838060595f602a7@google.com> <20191028133050.GA13691@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 28, 2019 at 02:55:52PM +0100, Takashi Iwai wrote: > On Mon, 28 Oct 2019 14:30:50 +0100, > Greg KH wrote: > > > > On Mon, Oct 28, 2019 at 02:13:20PM +0100, Takashi Iwai wrote: > > > On Mon, 28 Oct 2019 11:32:07 +0100, > > > syzbot wrote: > > > > > > > > Uninit was stored to memory at: > > > > kmsan_save_stack_with_flags mm/kmsan/kmsan.c:151 [inline] > > > > kmsan_internal_chain_origin+0xbd/0x180 mm/kmsan/kmsan.c:319 > > > > __msan_chain_origin+0x6b/0xd0 mm/kmsan/kmsan_instr.c:179 > > > > parse_term_proc_unit+0x73d/0x7e0 sound/usb/mixer.c:896 > > > > __check_input_term+0x13ef/0x2360 sound/usb/mixer.c:989 > > > > > > So this comes from the invalid descriptor for a processing unit, and > > > it's very likely the same issue as already spotted -- the validator up > > > to 5.3-rc4 had a bug that passed the invalid descriptor falsely. > > > This should have been covered by 5.3-rc5, commit ba8bf0967a15 ("ALSA: > > > usb-audio: Fix copy&paste error in the validator"). > > > > SHould we be backporting the validator to any older kernels as well? > > Yes, that would be nice. I didn't mark them for stable just because > they are a bit largish and wanted to let them tested for 5.4 for a > while. > > The following commits are relevant (from top/old to bottom/new). > > 57f8770620e9b51c61089751f0b5ad3dbe376ff2 > ALSA: usb-audio: More validations of descriptor units > 68e9fde245591d18200f8a9054cac22339437adb > ALSA: usb-audio: Simplify parse_audio_unit() > 52c3e317a857091fd746e15179a637f32be4d337 > ALSA: usb-audio: Unify the release of usb_mixer_elem_info objects > b8e4f1fdfa422398c2d6c47bfb7d1feb3046d70a > ALSA: usb-audio: Remove superfluous bLength checks > e0ccdef92653f8867e2d1667facfd3c23699f540 > ALSA: usb-audio: Clean up check_input_term() > 60849562a5db4a1eee2160167e4dce4590d3eafe > ALSA: usb-audio: Fix possible NULL dereference at create_yamaha_midi_quirk() > b39e077fcb283dd96dd251a3abeba585402c61fe > ALSA: usb-audio: remove some dead code > ba8bf0967a154796be15c4983603aad0b05c3138 > ALSA: usb-audio: Fix copy&paste error in the validator > Thanks, I've queued this series up for 5.3.y and 4.19.y greg k-h