From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED505C43331 for ; Mon, 11 Nov 2019 13:18:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9FA82190F for ; Mon, 11 Nov 2019 13:18:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727016AbfKKNSY (ORCPT ); Mon, 11 Nov 2019 08:18:24 -0500 Received: from mx2.suse.de ([195.135.220.15]:45086 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726845AbfKKNSY (ORCPT ); Mon, 11 Nov 2019 08:18:24 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 05DF4B595; Mon, 11 Nov 2019 13:18:23 +0000 (UTC) Date: Mon, 11 Nov 2019 14:18:17 +0100 From: Michal =?iso-8859-1?Q?Such=E1nek?= To: Diego Elio =?iso-8859-1?Q?Petten=F2?= Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org Subject: Re: cdrom: make debug logging rely on pr_debug and debugfs only. Message-ID: <20191111131817.GA2770@kitsune.suse.cz> References: <20190826151640.5036-3-flameeyes@flameeyes.com> <20191103160030.GO1384@kitsune.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 11, 2019 at 12:21:38PM +0000, Diego Elio Pettenò wrote: > On Sun, Nov 3, 2019 at 4:00 PM Michal Suchánek wrote: > > can you change cd_dbg to a macro that always prints the device name > > using pr_debug instead of removing it? > > I can try doing that (need to figure out how, of course.) > > Should I split the change that removes the debug parameter / > ERRORLOGMASK parts? To be honest those are the parts that appear more > of a duplication than the macro itself, so it might make sense to > remove the custom debug selection, and then add the device name on top > of that? I wrote a patch that does just that because I am debugging an issue with cdrom and I need to know which device the messages relate to. Maybe you can drop this part entirely to not get conflicts. Thanks Michal