From: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
To: acme@kernel.org
Cc: jolsa@redhat.com, kan.liang@intel.com,
linux-kernel@vger.kernel.org,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Subject: [PATCH] perf report: Fix segfault with '-F phys_daddr'
Date: Tue, 12 Nov 2019 11:19:46 +0530 [thread overview]
Message-ID: <20191112054946.5869-1-ravi.bangoria@linux.ibm.com> (raw)
If perf.data file is not recorded with mem-info, adding 'phys_daddr'
to output field in perf report results in segfault. Fix that.
Before:
$ ./perf record ls
$ ./perf report -F +phys_daddr
Segmentation fault (core dumped)
After:
$ ./perf report -F +phys_daddr
Samples: 11 of event 'cycles:u', Event count (approx.): 1485821
Overhead Data Physical Address Command Shared Object Symbol
22.57% [.] 0000000000000000 ls libc-2.29.so [.] __strcoll_l
21.87% [.] 0000000000000000 ls ld-2.29.so [.] _dl_relocate_object
...
Fixes: 8780fb25ab06 ("perf sort: Add sort option for physical address")
Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
---
tools/perf/util/sort.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index 43d1d410854a..c2430676e569 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -1413,7 +1413,7 @@ static int hist_entry__phys_daddr_snprintf(struct hist_entry *he, char *bf,
size_t ret = 0;
size_t len = BITS_PER_LONG / 4;
- addr = he->mem_info->daddr.phys_addr;
+ addr = he->mem_info ? he->mem_info->daddr.phys_addr : 0;
ret += repsep_snprintf(bf + ret, size - ret, "[%c] ", he->level);
--
2.21.0
next reply other threads:[~2019-11-12 5:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 5:49 Ravi Bangoria [this message]
2019-11-12 11:04 ` Arnaldo Carvalho de Melo
2019-11-12 13:58 ` Ravi Bangoria
2019-11-12 14:18 ` Arnaldo Carvalho de Melo
2019-11-12 14:20 ` Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112054946.5869-1-ravi.bangoria@linux.ibm.com \
--to=ravi.bangoria@linux.ibm.com \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®