From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 512D7C17441 for ; Tue, 12 Nov 2019 11:10:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 238F62084E for ; Tue, 12 Nov 2019 11:10:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727141AbfKLLKl (ORCPT ); Tue, 12 Nov 2019 06:10:41 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:47295 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725865AbfKLLKk (ORCPT ); Tue, 12 Nov 2019 06:10:40 -0500 Received: from [185.81.136.22] (helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iUU4C-0007qy-HD; Tue, 12 Nov 2019 11:10:36 +0000 Date: Tue, 12 Nov 2019 12:10:33 +0100 From: Christian Brauner To: Adrian Reber Cc: Shuah Khan , Eugene Syromiatnikov , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] selftests: add tests for clone3() Message-ID: <20191112111032.ncbbnd24lejujgxf@wittgenstein> References: <20191112095851.811884-1-areber@redhat.com> <20191112102814.xkml5etvogzsr7xq@wittgenstein> <20191112104505.66653mgk2da7rwyh@wittgenstein> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191112104505.66653mgk2da7rwyh@wittgenstein> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 12, 2019 at 11:45:05AM +0100, Christian Brauner wrote: > On Tue, Nov 12, 2019 at 11:28:14AM +0100, Christian Brauner wrote: > > On Tue, Nov 12, 2019 at 10:58:51AM +0100, Adrian Reber wrote: > > > This adds tests for clone3() with different values and sizes > > > of struct clone_args. > > > > > > This selftest was initially part of of the clone3() with PID selftest. > > > After that patch was almost merged Eugene sent out a couple of patches > > > to fix problems with these test. > > > > > > This commit now only contains the clone3() selftest after the LPC > > > decision to rework clone3() with PID to allow setting the PID in > > > multiple PID namespaces including all of Eugene's patches. > > > > > > Signed-off-by: Eugene Syromiatnikov > > > Signed-off-by: Adrian Reber > > > > Queuing up for 5.5. > > Thanks, Adrian! > > > > Reviewed-by: Christian Brauner > > One thing, can you tell me what the base tree for your commit is, > please? Given that this is just one commit it should be enough if you > give me the "base-commit" line from the end of the patch created via: > git format-patch --base=HEAD~1 HEAD~1 Ok, merge base commit seems to have been v5.4-rc7. I've resolved a minor merge conflict (cf. [2]) when applying this commit to [1]. Christian [1]: https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git/log/?h=pidfd [2]: diff --cc tools/testing/selftests/clone3/.gitignore index 6c9f98097774,85d9d3ba2524..000000000000 --- a/tools/testing/selftests/clone3/.gitignore +++ b/tools/testing/selftests/clone3/.gitignore @@@ -1,1 -1,1 +1,2 @@@ + clone3 +clone3_clear_sighand diff --cc tools/testing/selftests/clone3/Makefile index e6f259321e16,ea922c014ae4..000000000000 --- a/tools/testing/selftests/clone3/Makefile +++ b/tools/testing/selftests/clone3/Makefile @@@ -1,6 -1,7 +1,6 @@@ - # SPDX-License-Identifier: GPL-2.0-only + # SPDX-License-Identifier: GPL-2.0 +CFLAGS += -g -I../../../../usr/include/ - TEST_GEN_PROGS := clone3_clear_sighand -CFLAGS += -I../../../../usr/include/ - -TEST_GEN_PROGS := clone3 ++TEST_GEN_PROGS := clone3 clone3_clear_sighand include ../lib.mk