From: Will Deacon <will@kernel.org>
To: Xiao Yang <ice_yangxiao@163.com>
Cc: linux-arch@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
yamada.masahiro@socionext.com, ast@kernel.org,
daniel@iogearbox.net
Subject: Re: Question about "asm/rwonce.h: No such file or directory"
Date: Tue, 12 Nov 2019 12:31:26 +0000 [thread overview]
Message-ID: <20191112123125.GD17835@willie-the-truck> (raw)
In-Reply-To: <1da2db04-da6a-cedb-e85a-6ded68dada82@163.com>
[+lkml, Masahiro, Alexei and Daniel]
On Tue, Nov 12, 2019 at 04:56:39PM +0800, Xiao Yang wrote:
> With your patch[1], I alway get the following error when building
> tools/bpf:
In case people want to reproduce this, my branch is here:
https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git/log/?h=lto
> ----------------------------------------------------------------------------------
>
> make -C tools/bpf/
> make: Entering directory
> '/usr/src/perf_selftests-x86_64-rhel-7.6-642a312d47ceb54603630d9d04f5052f3b46d9a3/tools/bpf'
>
> Auto-detecting system features:
> ... libbfd: [ on ]
> ... disassembler-four-args: [ OFF ]
>
> CC bpf_jit_disasm.o
> CC bpf_dbg.o
> In file included from
> /usr/src/perf_selftests-x86_64-rhel-7.6-642a312d47ceb54603630d9d04f5052f3b46d9a3/include/uapi/linux/filter.h:9:0,
> from
> /usr/src/perf_selftests-x86_64-rhel-7.6-642a312d47ceb54603630d9d04f5052f3b46d9a3/tools/bpf/bpf_dbg.c:41:
> /usr/src/perf_selftests-x86_64-rhel-7.6-642a312d47ceb54603630d9d04f5052f3b46d9a3/include/linux/compiler.h:247:24:
> fatal error: asm/rwonce.h: No such file or directory
> #include <asm/rwonce.h>
> ^
> compilation terminated.
> Makefile:61: recipe for target 'bpf_dbg.o' failed
> make: *** [bpf_dbg.o] Error 1
> make: *** Waiting for unfinished jobs....
> make: Leaving directory
>
> ----------------------------------------------------------------------------------
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git/commit/?h=lto&id=642a312d47ceb54603630d9d04f5052f3b46d9a3
>
> It seems that include/linux/compiler.h cannot find the asm/rwonce.h because
> tools/bpf/Makefile doesn't include arch/*/include/generated/asm/rwonce.h.
The problem with referring to the generated files is that they don't exist
unless you've configured the main source directory. The real problem here
seems to be that tools/bpf/ refers directly to header files in the kernel
sources without any understanding of kbuild, and therefore mandatory-y
headers simply don't exist when it goes looking for them.
Perhaps it's possible to introduce a dependency on a top-level "make
asm-generic" so that we can reference the generated headers from the arch
directly. Thoughts?
Will
next parent reply other threads:[~2019-11-12 12:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1da2db04-da6a-cedb-e85a-6ded68dada82@163.com>
2019-11-12 12:31 ` Will Deacon [this message]
2019-11-12 12:50 ` Masahiro Yamada
2019-11-12 15:13 ` Daniel Borkmann
2019-11-13 3:44 ` Xiao Yang
2019-11-13 5:28 ` Masahiro Yamada
2019-11-13 5:51 ` Xiao Yang
2019-11-13 6:57 ` Masahiro Yamada
2019-11-13 7:16 ` Xiao Yang
2019-11-13 7:53 ` Masahiro Yamada
2019-11-13 8:35 ` Xiao Yang
2019-11-13 8:54 ` Masahiro Yamada
2019-11-13 14:55 ` Xiao Yang
2019-11-13 15:48 ` Masahiro Yamada
2019-11-13 0:59 ` Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112123125.GD17835@willie-the-truck \
--to=will@kernel.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=ice_yangxiao@163.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®