From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Jessica Yu <jeyu@kernel.org>, Prarit Bhargava <prarit@redhat.com>,
Barret Rhoden <brho@google.com>
Cc: Konstantin Khorenko <khorenko@virtuozzo.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
linux-kernel@vger.kernel.org, David Arcari <darcari@redhat.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: [PATCH 0/1] kernel/module.c: don't allow modprobe to hang forever on a module load
Date: Wed, 13 Nov 2019 12:29:49 +0300 [thread overview]
Message-ID: <20191113092950.15556-1-khorenko@virtuozzo.com> (raw)
After commit 6e6de3dee51a ("kernel/module.c: Only return -EEXIST
for modules that have finished loading")
the simple test leads to hanged modprobe process (INTERRUPTIBLE):
1. Make sure nft_ct module is not used by your firewall rules.
2. Run 3 copies of
# export i=0; while true; if [[ $(($i % 100)) -eq 0 ]] ; then \
echo "i=$i"; fi; do modprobe nft_ct; i=$(($i + 1)); done
3. Run 2 copies of
# while true; do rmmod nft_ct; done
Hanged "modprobe" process will appear in ~ 10 seconds.
# cat /proc/30184/stack
[<0>] load_module+0x53f/0x2060
[<0>] __do_sys_finit_module+0xd2/0x100
[<0>] do_syscall_64+0x5b/0x1c0
[<0>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
Konstantin Khorenko (1):
kernel/module.c: wakeup processes in module_wq on module unload
kernel/module.c | 2 ++
1 file changed, 2 insertions(+)
--
2.15.1
next reply other threads:[~2019-11-13 9:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 9:29 Konstantin Khorenko [this message]
2019-11-13 9:29 ` [PATCH 1/1] kernel/module.c: wakeup processes in module_wq on module unload Konstantin Khorenko
2019-11-13 13:51 ` Prarit Bhargava
2019-11-15 10:28 ` Jessica Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113092950.15556-1-khorenko@virtuozzo.com \
--to=khorenko@virtuozzo.com \
--cc=aryabinin@virtuozzo.com \
--cc=brho@google.com \
--cc=darcari@redhat.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®