From: Adrian Reber <areber@redhat.com>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Eric Biederman <ebiederm@xmission.com>,
Pavel Emelyanov <ovzxemul@gmail.com>,
Jann Horn <jannh@google.com>, Oleg Nesterov <oleg@redhat.com>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-kernel@vger.kernel.org, Andrei Vagin <avagin@gmail.com>,
Mike Rapoport <rppt@linux.ibm.com>,
Radostin Stoyanov <rstoyanov1@gmail.com>
Subject: Re: [PATCH v9 1/2] fork: extend clone3() to support setting a PID
Date: Thu, 14 Nov 2019 09:22:09 +0100 [thread overview]
Message-ID: <20191114082209.GE1252861@dcbz.redhat.com> (raw)
In-Reply-To: <20191114081359.axnoioa25grf3ffv@wittgenstein>
On Thu, Nov 14, 2019 at 09:14:00AM +0100, Christian Brauner wrote:
> On Thu, Nov 14, 2019 at 08:07:08AM +0100, Adrian Reber wrote:
> > * The structure is versioned by size and thus extensible.
> > * New struct members must go at the end of the struct and
> > @@ -71,6 +85,8 @@ struct clone_args {
> > __aligned_u64 stack;
> > __aligned_u64 stack_size;
> > __aligned_u64 tls;
> > + __aligned_u64 set_tid;
> > + __aligned_u64 set_tid_size;
>
> Oh, one thing that is missing is the addition of
>
> +#define CLONE_ARGS_SIZE_VER1 80 /* sizeof second published struct */
>
> in sched.h. Please add that, when you resend.
Even if it is unused?
Adrian
next prev parent reply other threads:[~2019-11-14 8:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 7:07 Adrian Reber
2019-11-14 7:07 ` [PATCH v9 2/2] selftests: add tests for clone3() with *set_tid Adrian Reber
2019-11-14 8:38 ` Christian Brauner
2019-11-14 7:58 ` [PATCH v9 1/2] fork: extend clone3() to support setting a PID Christian Brauner
2019-11-14 8:02 ` Christian Brauner
2019-11-14 8:14 ` Christian Brauner
2019-11-14 8:22 ` Adrian Reber [this message]
2019-11-14 8:32 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114082209.GE1252861@dcbz.redhat.com \
--to=areber@redhat.com \
--cc=0x7f454c46@gmail.com \
--cc=avagin@gmail.com \
--cc=christian.brauner@ubuntu.com \
--cc=ebiederm@xmission.com \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=oleg@redhat.com \
--cc=ovzxemul@gmail.com \
--cc=rppt@linux.ibm.com \
--cc=rstoyanov1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®