mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Petr Mladek <pmladek@suse.com>
Cc: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] checkpatch: don't warn about new vsprintf pointer extension '%pe'
Date: Thu, 14 Nov 2019 11:33:50 +0100	[thread overview]
Message-ID: <20191114103350.z3fe4vzgepsb52y6@pengutronix.de> (raw)
In-Reply-To: <20191114102440.msyuahilbagaz7aw@pathway.suse.cz>

On Thu, Nov 14, 2019 at 11:24:40AM +0100, Petr Mladek wrote:
> On Thu 2019-11-14 11:04:16, Uwe Kleine-König wrote:
> > This extension was introduced in commit 57f5677e535b ("printf: add
> > support for printing symbolic error names").
> 
> Great catch!

It wasn't hard to catch. checkpatch pelted me with bogus warnings when I
started to make use of %pe :-)

> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> >  scripts/checkpatch.pl | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 6fcc66afb088..31cd9b767c1e 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -6022,7 +6022,7 @@ sub process {
> >  				while ($fmt =~ /(\%[\*\d\.]*p(\w))/g) {
> >  					$specifier = $1;
> >  					$extension = $2;
> > -					if ($extension !~ /[SsBKRraEhMmIiUDdgVCbGNOxt]/) {
> > +					if ($extension !~ /[SsBKRraeEhMmIiUDdgVCbGNOxt]/) {
> 
> I am going to push it into printk.git. I will just change the ordering
> "eE" -> "Ee". So that it follows the existing convention.

Fine for me. Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

  reply	other threads:[~2019-11-14 10:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-14 10:04 Uwe Kleine-König
2019-11-14 10:14 ` Rasmus Villemoes
2019-11-14 10:24 ` Petr Mladek
2019-11-14 10:33   ` Uwe Kleine-König [this message]
2019-11-14 14:01     ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191114103350.z3fe4vzgepsb52y6@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=andy.shevchenko@gmail.com \
    --cc=apw@canonical.com \
    --cc=joe@perches.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®