From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Shile Zhang <shile.zhang@linux.alibaba.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [RFC PATCH v4 0/7] Speed booting by sorting ORC unwind tables at build time
Date: Fri, 15 Nov 2019 11:52:24 -0600 [thread overview]
Message-ID: <20191115175224.ozuiei2vlfvynok5@treble> (raw)
In-Reply-To: <20191115164539.57930-1-shile.zhang@linux.alibaba.com>
On Sat, Nov 16, 2019 at 12:45:32AM +0800, Shile Zhang wrote:
> Hi,
>
> I refactored the code, followed by Peter's suggestions in v3, thank you!
> Any suggestions and comments are welcome!
>
> Thanks!
>
> Changelog:
> ==========
> v3->v4:
> - Code refactored for Peter's review findings and suggestions.
Hi Shile,
I haven't given it a proper review yet, but one minor suggestion. In
general it's good practice to wait at least a few business days before
posting a new version of a patch set. That way it gives people time to
review, and it also helps to avoid flooding people's inboxes.
--
Josh
next prev parent reply other threads:[~2019-11-15 17:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 16:45 Shile Zhang
2019-11-15 16:45 ` [RFC PATCH v4 1/7] scripts/sortextable: Rewrite error/success handling Shile Zhang
2019-11-15 16:45 ` [RFC PATCH v4 2/7] scripts/sortextable: kernel coding style formating Shile Zhang
2019-11-15 16:45 ` [RFC PATCH v4 3/7] scripts/sortextable: Remove dead code Shile Zhang
2019-11-15 16:45 ` [RFC PATCH v4 4/7] scripts/sortextable: refactor do_func() function Shile Zhang
2019-11-15 16:45 ` [RFC PATCH v4 5/7] scripts/sorttable: rename sortextable to sorttable Shile Zhang
2019-11-15 16:45 ` [RFC PATCH v4 6/7] scripts/sorttable: Add ORC unwind tables sort concurrently Shile Zhang
2019-11-15 16:45 ` [RFC PATCH v4 7/7] x86/unwind/orc: remove run-time ORC unwind tables sort Shile Zhang
2019-11-15 17:52 ` Josh Poimboeuf [this message]
2019-11-18 1:57 ` [RFC PATCH v4 0/7] Speed booting by sorting ORC unwind tables at build time Shile Zhang
2019-11-18 2:18 ` hpa
2019-11-18 2:27 ` Shile Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115175224.ozuiei2vlfvynok5@treble \
--to=jpoimboe@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=shile.zhang@linux.alibaba.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®