From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F37BC432C3 for ; Fri, 15 Nov 2019 18:01:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 705C420674 for ; Fri, 15 Nov 2019 18:01:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727050AbfKOSBK (ORCPT ); Fri, 15 Nov 2019 13:01:10 -0500 Received: from mga07.intel.com ([134.134.136.100]:19982 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726992AbfKOSBF (ORCPT ); Fri, 15 Nov 2019 13:01:05 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2019 10:01:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,309,1569308400"; d="scan'208";a="195460801" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga007.jf.intel.com with ESMTP; 15 Nov 2019 10:00:56 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 99C70EB; Fri, 15 Nov 2019 20:00:55 +0200 (EET) From: Andy Shevchenko To: linux-kernel@vger.kernel.org, Christoph Hellwig Cc: Andy Shevchenko , Dan Williams , Arnd Bergmann , Marek Szyprowski , Robin Murphy , Jaroslav Kysela , Takashi Iwai , Pierre-Louis Bossart , Ard Biesheuvel , Alex Williamson , Cornelia Huck Subject: [PATCH v1 1/5] memremap: Check for size parameter Date: Fri, 15 Nov 2019 20:00:40 +0200 Message-Id: <20191115180044.83659-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no use of memremap() to be called with size = 0. Simple return NULL pointer and allow callers to drop this check. Fixes: 92281dee825f ("arch: introduce memremap()") Cc: Christoph Hellwig Cc: Dan Williams Cc: Arnd Bergmann Cc: Marek Szyprowski Cc: Robin Murphy Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Pierre-Louis Bossart Cc: Ard Biesheuvel Cc: Alex Williamson Cc: Cornelia Huck Signed-off-by: Andy Shevchenko --- kernel/iomem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/iomem.c b/kernel/iomem.c index 62c92e43aa0d..bf7a5fc32760 100644 --- a/kernel/iomem.c +++ b/kernel/iomem.c @@ -74,6 +74,9 @@ void *memremap(resource_size_t offset, size_t size, unsigned long flags) IORESOURCE_SYSTEM_RAM, IORES_DESC_NONE); void *addr = NULL; + if (!size) + return NULL; + if (!flags) return NULL; -- 2.24.0