From: "Pali Rohár" <pali.rohar@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Giovanni Mascellani <gio@debian.org>,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dell-smm-hwmon: Add support for disabling automatic BIOS fan control
Date: Sat, 16 Nov 2019 16:59:45 +0100 [thread overview]
Message-ID: <20191116155945.tivygva3rbbdolgz@pali> (raw)
In-Reply-To: <7bc8ec9a-f559-96c8-36fd-6e11a1420626@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
On Saturday 16 November 2019 07:53:10 Guenter Roeck wrote:
> On 11/16/19 6:58 AM, Pali Rohár wrote:
> > On Saturday 16 November 2019 15:06:49 Giovanni Mascellani wrote:
> > > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> > > index 4212d022d253..67b8c0adede8 100644
> > > --- a/drivers/hwmon/dell-smm-hwmon.c
> > > +++ b/drivers/hwmon/dell-smm-hwmon.c
> > > @@ -68,6 +68,8 @@ static uint i8k_pwm_mult;
> > > static uint i8k_fan_max = I8K_FAN_HIGH;
> > > static bool disallow_fan_type_call;
> > > static bool disallow_fan_support;
> > > +static unsigned int smm_manual_fan;
> > > +static unsigned int smm_auto_fan;
>
> The "smm_" prefix does not have any value here.
These variables store SMM command numbers and seems that in this patch
they were converted from macros "#define I8K_SMM_MANUAL_FAN 0x34a3"
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2019-11-16 15:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-16 14:06 Giovanni Mascellani
2019-11-16 14:58 ` Pali Rohár
2019-11-16 15:53 ` Guenter Roeck
2019-11-16 15:59 ` Pali Rohár [this message]
2019-11-16 17:12 ` Giovanni Mascellani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191116155945.tivygva3rbbdolgz@pali \
--to=pali.rohar@gmail.com \
--cc=gio@debian.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®