From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2E63C432C0 for ; Sun, 17 Nov 2019 18:08:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 890D220700 for ; Sun, 17 Nov 2019 18:08:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TNBP7Y9z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726237AbfKQSIx (ORCPT ); Sun, 17 Nov 2019 13:08:53 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:49230 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726062AbfKQSIx (ORCPT ); Sun, 17 Nov 2019 13:08:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574014132; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eSxCHgdI3j2NAMCC1olhatH3DrTY9N/2Xvc86ib3ruI=; b=TNBP7Y9zbDW7+ix1gsBLW/eXAjU3p7MrRHFijhA562tHtvuHsCjqTRVAh5rwTHdQxUmcRu vXQ1PzKGg115ok/cGORpBG9Yu9jBc1WLupfLFlbg1WIU33MTfuJyxE+JQ9v9A6ijK3yRCJ yW2r0qFxjg5ej1bhbS+nAQ8gvzLq03g= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-377-XZmVUBuVOfW7R3xA8pInHw-1; Sun, 17 Nov 2019 13:08:51 -0500 Received: by mail-pg1-f198.google.com with SMTP id c10so11513353pgm.14 for ; Sun, 17 Nov 2019 10:08:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=nhPTTch4TLiEOOJDKHZfBwdD5XFDvnafgmAjZS61rz8=; b=q5+v6pasvh3yZx+AnE/ydMV2FEvxwDScXiMj2EfpxXvspajl7EMtp7JPzfEbnbAISc h6PyIBNRyoFn6RAWJMMLTaoueWAPgVjNUwdUDEGO5Ly+qw3Uyn2yw8MDkpgfoCMAw7FJ ibCVNoJtjAIM9erkwmSMKOb/cOszrsTjMlnjwbT4Lz8s4JIHCLYzOKLNdBIh68iWoFfs PI0Z5O+NujcyTrDq50IwEi++pjTzhEmMmIqsaT6GbC9Nc/vNiw69P78pRkMa2j54Fl3b mbVky/6ViX0YWCEqqZjPqMzE+m0+SJd6aufbV1JJSM4IwrVQODyD22nwP9bLzJzHjJnD bkow== X-Gm-Message-State: APjAAAUucp7X6Mj0LtJIO1S642zj+xlwoen+/SoirjY62m1Z2NkBcthI e+o7a6l2yKJNpcxN4Oy7sA54aVdCqaqZTjy7PauxIcQ9K9qeaC6jHExjhnyH3jTbv97MVj55zbs I0SSKa2/74+ddpdjk34ZHu63O X-Received: by 2002:a63:cc56:: with SMTP id q22mr10365502pgi.439.1574014130314; Sun, 17 Nov 2019 10:08:50 -0800 (PST) X-Google-Smtp-Source: APXvYqxg590xxVEGOOIe1dNaEgjxSEw82NPd5dgH3ztF+eBVj9rHMhiez57C0XKIHEcdFsYXYYKOBA== X-Received: by 2002:a63:cc56:: with SMTP id q22mr10365473pgi.439.1574014130039; Sun, 17 Nov 2019 10:08:50 -0800 (PST) Received: from localhost (ip70-163-223-149.ph.ph.cox.net. [70.163.223.149]) by smtp.gmail.com with ESMTPSA id j186sm17803718pfg.161.2019.11.17.10.08.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Nov 2019 10:08:48 -0800 (PST) Date: Sun, 17 Nov 2019 11:08:47 -0700 From: Jerry Snitselaar To: Stefan Berger Cc: Jarkko Sakkinen , Stefan Berger , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH] tpm_tis: Move setting of TPM_CHIP_FLAG_IRQ into tpm_tis_probe_irq_single Message-ID: <20191117180847.322467cqngpbpael@cantor> Reply-To: Jerry Snitselaar Mail-Followup-To: Stefan Berger , Jarkko Sakkinen , Stefan Berger , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org References: <20191112202725.3009814-1-stefanb@linux.vnet.ibm.com> <20191114164151.GB9528@linux.intel.com> <20191114164426.GC9528@linux.intel.com> <185664a9-58f2-2a4b-4e6b-8d7750a35690@linux.ibm.com> MIME-Version: 1.0 In-Reply-To: <185664a9-58f2-2a4b-4e6b-8d7750a35690@linux.ibm.com> X-MC-Unique: XZmVUBuVOfW7R3xA8pInHw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat Nov 16 19, Stefan Berger wrote: >On 11/14/19 11:44 AM, Jarkko Sakkinen wrote: >>On Thu, Nov 14, 2019 at 06:41:51PM +0200, Jarkko Sakkinen wrote: >>>On Tue, Nov 12, 2019 at 03:27:25PM -0500, Stefan Berger wrote: >>>>From: Stefan Berger >>>> >>>>Move the setting of the TPM_CHIP_FLAG_IRQ for irq probing into >>>>tpm_tis_probe_irq_single before calling tpm_tis_gen_interrupt. >>>>This move handles error conditions better that may arise if anything >>>>before fails in tpm_tis_probe_irq_single. >>>> >>>>Signed-off-by: Stefan Berger >>>>Suggested-by: Jerry Snitselaar >>>What about just changing the condition? >>Also cannot take this since it is not a bug (no fixes tag). > >I'll repost but will wait until Jerry has tested it on that machine. > >=A0=A0 Stefan > Sorry, I'm still waiting to hear back from the reporter, and logistics for some reason has been silent on my request so far. > >> >>/Jarkko > >