mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Robin H. Johnson" <robbat2@gentoo.org>
To: mcgrof@kernel.org
Cc: linux-kernel@vger.kernel.org, sir@cmpwn.com,
	~sircmpwn/public-inbox@lists.sr.ht, gregkh@linuxfoundation.org,
	rafael@kernel.org, "Robin H. Johnson" <robbat2@gentoo.org>
Subject: [PATCH v3] firmware: log name & outcome of loaded firmware
Date: Sun, 17 Nov 2019 15:47:34 -0800	[thread overview]
Message-ID: <20191117234734.27101-1-robbat2@gentoo.org> (raw)
In-Reply-To: <robbat2-20191113T195158-869302266Z@orbis-terrarum.net>

It's non-trivial to figure out names of firmware that was actually
loaded, add a debug statement at the end of _request_firmware that logs
the name & result of each firmware.

This is esp. valuable early in boot, before logging of UEVENT is
available.

v3:
- Log at dev_dbg level per maintainer.
- HOWTO: Enable at boot via kernel boot param
  dyndbg="func _request_firmware +p"
- Credit to Drew DeVault for parallel creation and help promoting the
  idea.

Alternate-Creation: Drew DeVault <sir@cmpwn.com>
Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
---
 drivers/base/firmware_loader/main.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c
index bf44c79beae9..84a879608ca4 100644
--- a/drivers/base/firmware_loader/main.c
+++ b/drivers/base/firmware_loader/main.c
@@ -791,6 +791,13 @@ _request_firmware(const struct firmware **firmware_p, const char *name,
 		fw = NULL;
 	}
 
+	/* Provide a consistent way to capture the result of trying to load any
+	 * firmware. As a potential future improvement, this might include
+	 * persistent state that firmware is loaded (or failed to load for some
+	 * reason). See Message-ID: <20191113205010.GY11244@42.do-not-panic.com>
+	 * for background */
+	dev_dbg(device, "%s %s ret=%d\n", __func__, name, ret);
+
 	*firmware_p = fw;
 	return ret;
 }
-- 
2.24.0


  parent reply	other threads:[~2019-11-17 23:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-03 18:06 [PATCH v2] firmware loader: log path to loaded firmwares Drew DeVault
2019-11-13  0:56 ` Luis Chamberlain
2019-11-13 14:05   ` Drew DeVault
2019-11-13 20:19   ` Robin H. Johnson
2019-11-13 20:50     ` Luis Chamberlain
2019-11-17 18:46       ` Drew DeVault
2019-11-17 23:47     ` Robin H. Johnson [this message]
2019-11-18 17:53       ` [PATCH v3] firmware: log name & outcome of loaded firmware Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191117234734.27101-1-robbat2@gentoo.org \
    --to=robbat2@gentoo.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=rafael@kernel.org \
    --cc=sir@cmpwn.com \
    --cc=~sircmpwn/public-inbox@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®