From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53F8BC432C0 for ; Tue, 19 Nov 2019 01:24:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E0972053B for ; Tue, 19 Nov 2019 01:24:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727234AbfKSBX7 (ORCPT ); Mon, 18 Nov 2019 20:23:59 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:52242 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726761AbfKSBX6 (ORCPT ); Mon, 18 Nov 2019 20:23:58 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 64C49150FAE7B; Mon, 18 Nov 2019 17:23:58 -0800 (PST) Date: Mon, 18 Nov 2019 17:23:58 -0800 (PST) Message-Id: <20191118.172358.1651088156867288729.davem@davemloft.net> To: colin.king@canonical.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, dmurphy@ti.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] net: phy: dp83869: fix return of uninitialized variable ret From: David Miller In-Reply-To: <20191118114835.39494-1-colin.king@canonical.com> References: <20191118114835.39494-1-colin.king@canonical.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 18 Nov 2019 17:23:58 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Mon, 18 Nov 2019 11:48:35 +0000 > From: Colin Ian King > > In the case where the call to phy_interface_is_rgmii returns zero > the variable ret is left uninitialized and this is returned at > the end of the function dp83869_configure_rgmii. Fix this by > returning 0 instead of the uninitialized value in ret. > > Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: 01db923e8377 ("net: phy: dp83869: Add TI dp83869 phy") > Signed-off-by: Colin Ian King Applied.