From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4786C43215 for ; Mon, 18 Nov 2019 17:45:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C00CA2192B for ; Mon, 18 Nov 2019 17:45:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574099155; bh=6nGZwtWAlbAkR03LsyKRIzmdzSFqC4ZcoruSPOH4V4g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=yPAWE0tVRU9nMdhQKilu1qGbghdaJbNkTGxYvaw6e9q/tRsRaRo+4qlae52Sav3Yr PCNUd07tRJl/D8ugkO4KmpjF6MB5zXFGq/lzJgga+BoKCFEeUGcESarHglUbx0VtEP yVq5cNT5H8FPbIftqZGcSlTQfjJEr0S43lsrct2U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726760AbfKRRpz (ORCPT ); Mon, 18 Nov 2019 12:45:55 -0500 Received: from foss.arm.com ([217.140.110.172]:37786 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726336AbfKRRpy (ORCPT ); Mon, 18 Nov 2019 12:45:54 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F0DD61FB; Mon, 18 Nov 2019 09:45:53 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 41CE73F703; Mon, 18 Nov 2019 09:45:53 -0800 (PST) Date: Mon, 18 Nov 2019 17:45:50 +0000 From: Mark Brown To: Sven Van Asbroeck Cc: Lee Jones , Liam Girdwood , Jacek Anaszewski , Pavel Machek , Rob Herring , Linus Walleij , Grigoryev Denis , Axel Lin , Dan Murphy , Mark Rutland , devicetree , Linux Kernel Mailing List , linux-leds@vger.kernel.org Subject: Re: [PATCH v1 1/4] tps6105x: add optional devicetree support Message-ID: <20191118174550.GA43585@sirena.org.uk> References: <20191118165400.21985-1-TheSven73@gmail.com> <20191118165400.21985-2-TheSven73@gmail.com> <20191118170111.GL9761@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="UlVJffcvxoiEqYs2" Content-Disposition: inline In-Reply-To: X-Cookie: Are we live or on tape? User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --UlVJffcvxoiEqYs2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 18, 2019 at 12:17:50PM -0500, Sven Van Asbroeck wrote: > On Mon, Nov 18, 2019 at 12:01 PM Mark Brown wrote: > > We shouldn't need a compatible here, the MFD should just instantiate any > > children it has. > If the child node doesn't have a compatible, how would the driver be > able to work > out the operational mode? The chip can only be in a single operational mode > at a time. So the child node has 'led' or 'regulator' compatible. > Or is there a more elegant method I've overlooked? So this is one device that has two separate modes? This sounds like you need a property specifying how the device is wired up, or possibly just different compatibles at the root of the device though that's not quite idiomatic. Splitting this up with different devices is a bit of a Linux specific implementation detail. --UlVJffcvxoiEqYs2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl3S2M4ACgkQJNaLcl1U h9ByRwf/VC4ZC3Kltc9gqSB2/giau7AxR0MHzi1gENgbr3VxEfOvL5DhGt/j6koE igDgKqsCtFSpZCCjYHinsCW9s8ue4r3ZIN9Kk6jpZUR1h+ddomrpkywGnGhKpUlB ZLJM23qgScm72XM5i17kzut4vBhSHKPlcOAQr00ZLPuQVj1keflO3hNIq7Suk3fP yAn+romZT4vbfHgPbylFOjm6syNioCOIUjVhl7YCjFfYVO8GOE6aQoGPUsLHGxbZ UYu0F+XjqG1ZArQhaGdMz8/6t4S/MVCCwayEcQ23SHIdWn2LYghmGpMuXOauKAtK J+sV/ijwbpJxaKN3MyZwVaRUEYIUnQ== =dQrA -----END PGP SIGNATURE----- --UlVJffcvxoiEqYs2--