From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DF32C43215 for ; Mon, 18 Nov 2019 20:34:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E2C0A22303 for ; Mon, 18 Nov 2019 20:34:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574109251; bh=zT5xieo5s1d7/87J92eKpsMK/gmDLcvEqHP61vKhaDg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Y5NfTuCeEzsO+k9Yz22zrmycOWHbVlkHln9dct+ADjBOljQl85jNeNLBEOO/EOJSp jKNBaIXNMn/CTPhH8IZBOowOl5RQQTC0JgN2NxnHxePFODqAyIhySNv8GLMZr8XwEb GkSkl0Co5R7P7L88hZd4fDZp0uiDAgJaxJogo+k8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727036AbfKRUeK (ORCPT ); Mon, 18 Nov 2019 15:34:10 -0500 Received: from foss.arm.com ([217.140.110.172]:39798 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726536AbfKRUeJ (ORCPT ); Mon, 18 Nov 2019 15:34:09 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C5AE0328; Mon, 18 Nov 2019 12:34:08 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 253EF3F6C4; Mon, 18 Nov 2019 12:34:07 -0800 (PST) Date: Mon, 18 Nov 2019 20:34:06 +0000 From: Mark Brown To: Sven Van Asbroeck Cc: Lee Jones , Liam Girdwood , Jacek Anaszewski , Pavel Machek , Rob Herring , Linus Walleij , Grigoryev Denis , Axel Lin , Dan Murphy , Mark Rutland , devicetree , Linux Kernel Mailing List , linux-leds@vger.kernel.org Subject: Re: [PATCH v1 1/4] tps6105x: add optional devicetree support Message-ID: <20191118203406.GE43585@sirena.org.uk> References: <20191118165400.21985-1-TheSven73@gmail.com> <20191118165400.21985-2-TheSven73@gmail.com> <20191118170111.GL9761@sirena.org.uk> <20191118174550.GA43585@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wTWi5aaYRw9ix9vO" Content-Disposition: inline In-Reply-To: X-Cookie: Are we live or on tape? User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --wTWi5aaYRw9ix9vO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 18, 2019 at 01:13:24PM -0500, Sven Van Asbroeck wrote: > This mfd chip can be wired up as one of the following: > - gpio only > - gpio + regulator > - gpio + led > - gpio + flash Is the regulator bit of this perhaps a voltage regulator and a current regulator packaged together mainly for use powering LEDs? That's a hardware design I've seen before... > in this case, there is no elegant way to specify the regulator properties in > the devicetree. Except by grabbing a reference to a subnode perhaps. And then > I'd have to somehow make sure that the sub driver's device->of_node points > at this subnode, which the mfd core doesn't do automatically. Just point the regulator framework at the MFD's DT node - the children of the MFD can look at the parent device happily, there's several existing MFDs do this. --wTWi5aaYRw9ix9vO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl3TAD0ACgkQJNaLcl1U h9Bqlgf8Dib7KYvT7366jnJriGkt0NV9PQ/TYCN+prAOuGPFTXGKFfvvoDwmk+Tc 1iVLFjL50q8VMfkPpi2AbDZM0MjA7eir/yIOyg9hxutkWz+ttnnELQEUORVSdGhp WF+GwkGMYn3kuFysi9uhPs+yX2gLPFia6TcxxiLkR8I/nOIWT36Lc3mEpu401yUN MP24CU830l7Su2ip1HgyoNuuI5vfJWvnpQKSo0Kz9iBFVgVlpDhNnPGXar9d3PQO c3LxleG+Y+SPXdmXpPE86ENAuAmVoxHU3W03m+rs4QhouK3EX/hjwVI9mASUZxoW YrENReY3z5W6007+5oh7wzABjwVxZQ== =7W1d -----END PGP SIGNATURE----- --wTWi5aaYRw9ix9vO--