From: David Miller <davem@davemloft.net>
To: hslester96@gmail.com
Cc: fugang.duan@nxp.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3] net: fec: fix clock count mis-match
Date: Tue, 19 Nov 2019 14:55:13 -0800 (PST) [thread overview]
Message-ID: <20191119.145513.561465860770576481.davem@davemloft.net> (raw)
In-Reply-To: <20191118121826.26353-1-hslester96@gmail.com>
From: Chuhong Yuan <hslester96@gmail.com>
Date: Mon, 18 Nov 2019 20:18:26 +0800
> pm_runtime_put_autosuspend in probe will call suspend to disable clks
> automatically if CONFIG_PM is defined. (If CONFIG_PM is not defined,
> its implementation will be empty, then suspend will not be called.)
>
> Therefore, we can call pm_runtime_get_sync to resume it first to enable
> clks, which matches the suspend. (Only when CONFIG_PM is defined, otherwise
> pm_runtime_get_sync will also be empty, then resume will not be called.)
>
> Then it is fine to disable clks without causing clock count mis-match.
>
> Fixes: c43eab3eddb4 ("net: fec: add missed clk_disable_unprepare in remove")
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Please fix the commit message typos pointed out by Andy Duan and resubmit,
thank you.
prev parent reply other threads:[~2019-11-19 22:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 12:18 Chuhong Yuan
2019-11-19 1:49 ` [EXT] " Andy Duan
2019-11-19 22:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119.145513.561465860770576481.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fugang.duan@nxp.com \
--cc=hslester96@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®