From: Mark Brown <broonie@kernel.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: regmap-w1: Drop unreachable code
Date: Tue, 19 Nov 2019 13:07:32 +0000 [thread overview]
Message-ID: <20191119130732.GB3634@sirena.org.uk> (raw)
In-Reply-To: <20191119125837.47619-1-mika.westerberg@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 271 bytes --]
On Tue, Nov 19, 2019 at 03:58:37PM +0300, Mika Westerberg wrote:
> Both init functions have a stray "return NULL" at the end which is never
> reached so drop them.
>
> Fixes: cc5d0db390b0 ("regmap: Add 1-Wire bus support")
You're overusing the Fixes tag here...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-11-19 13:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 12:58 Mika Westerberg
2019-11-19 13:07 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119130732.GB3634@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®