From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81F32C432C3 for ; Tue, 19 Nov 2019 21:37:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 56EB521D7F for ; Tue, 19 Nov 2019 21:37:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=flameeyes-com.20150623.gappssmtp.com header.i=@flameeyes-com.20150623.gappssmtp.com header.b="tE/C24Ec" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727390AbfKSVhh (ORCPT ); Tue, 19 Nov 2019 16:37:37 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:36043 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726911AbfKSVhg (ORCPT ); Tue, 19 Nov 2019 16:37:36 -0500 Received: by mail-wm1-f65.google.com with SMTP id c22so5575840wmd.1 for ; Tue, 19 Nov 2019 13:37:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flameeyes-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EUCwF1LzJLvsN7CqOcV9XgCxKH6O+I2o02sRA/ocWcg=; b=tE/C24EcDf+siaLLJiKehEkKir67hqAqLZ0CHsfvHjfepvqomS5j8L+YyH9DV9SKxA uGKwRZYH1QiqH6RDhfaWfatt2qbn+2at2x69Sni3SM2VAJHrBd5/ZCRthKelOU2OPjNb ay9f21f1ge1diCNOla/Bjar232huEqoyPOlrGzO7Z9/yIDUVPG4b4WBlSV2ArT+PZg30 XIH/ZfPil28uM0L2tG5xUqUbQMvFyO2cAnlcdqK/ieRNONBRNrj/hXvXJFRMkoE1vxlz 1q8Z+uqCm3pf2X+XW9cosK+Pt22yBz9flJfp4PcCf+rkr+jbMEwW5I+rOr67JiHq/B2L +0ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EUCwF1LzJLvsN7CqOcV9XgCxKH6O+I2o02sRA/ocWcg=; b=KX/26EcotmF9RrND+W4hO7Hmxrqa5yQmQXO71a7675ssGn9WTpgNEfxIuVkxWlPu37 Zrslrn/AV0lY46D1XmP0ryb/o13fqkqMPWpe2ZhoAYr+wBBtLIN0WZMmwNGy/WlFoeR9 b+xvZRXZ3R3MJ95TGdOhhY9Wf2rx5ePKwEEh31DC8jyE9C5O5M374n7CtwLnW6EaZJM4 4n4UaJNWXg0Dae/zRsanXJOzVFKrOge4+Gmoe1nsruZi7R0gO47dOsP2W4K+W5OexKOT SpLrcZqdyUxbhI+MVGOcd87NBnAUobNih4hm2S8SbUsja5Omk4XS6fVQ2UOJ4QImlhRo hHvA== X-Gm-Message-State: APjAAAWd0tY/2XJ+UkOFJ7757xvTcNk09cy0oYho3dn1NL+zabieQNIT iptUVzYPL/G2p8BbWEMvjLpDNw== X-Google-Smtp-Source: APXvYqy7q9ekcOYfFtC6xl/Y4NYVCXMi/bH334HVz/Mi24sqmyw0R+YampRJBYl4L4HGXpVje1mWng== X-Received: by 2002:a05:600c:1002:: with SMTP id c2mr8464689wmc.79.1574199454277; Tue, 19 Nov 2019 13:37:34 -0800 (PST) Received: from localhost ([2a01:4b00:80c6:1000:283d:d5ff:fee6:36c5]) by smtp.gmail.com with ESMTPSA id w12sm4393628wmi.17.2019.11.19.13.37.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Nov 2019 13:37:33 -0800 (PST) From: =?UTF-8?q?Diego=20Elio=20Petten=C3=B2?= To: Jens Axboe Cc: =?UTF-8?q?Diego=20Elio=20Petten=C3=B2?= , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: [PATCH 2/2] sr_vendor: support Beurer GL50 evo CD-on-a-chip devices. Date: Tue, 19 Nov 2019 21:37:09 +0000 Message-Id: <20191119213709.10900-2-flameeyes@flameeyes.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191119213709.10900-1-flameeyes@flameeyes.com> References: <20191119213709.10900-1-flameeyes@flameeyes.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Beurer GL50 evo uses a Cygnal-manufactured CD-on-a-chip that only accepts a subset of SCSI commands, and supports neither audio commands nor generic packet commands. Actually sending those commands bring the device to an unrecoverable state that causes the device to hang and reset. To: Jens Axboe Cc: linux-kernel@vger.kernel.org Cc: linux-scsi@vger.kernel.org Signed-off-by: Diego Elio Pettenò --- drivers/scsi/sr_vendor.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/scsi/sr_vendor.c b/drivers/scsi/sr_vendor.c index e3b0ce25162b..17a56c87d383 100644 --- a/drivers/scsi/sr_vendor.c +++ b/drivers/scsi/sr_vendor.c @@ -61,6 +61,7 @@ #define VENDOR_NEC 2 #define VENDOR_TOSHIBA 3 #define VENDOR_WRITER 4 /* pre-scsi3 writers */ +#define VENDOR_CYGNAL_85ED 5 /* CD-on-a-chip */ #define VENDOR_TIMEOUT 30*HZ @@ -99,6 +100,23 @@ void sr_vendor_init(Scsi_CD *cd) } else if (!strncmp(vendor, "TOSHIBA", 7)) { cd->vendor = VENDOR_TOSHIBA; + } else if (!strncmp(vendor, "Beurer", 6) && + !strncmp(model, "Gluco Memory", 12)) { + /* The Beurer GL50 evo uses a Cygnal-manufactured CD-on-a-chip + that only accepts a subset of SCSI commands. Most of the + not-implemented commands are fine to fail, but a few, + particularly around the MMC or Audio commands, will put the + device into an unrecoverable state, so they need to be + avoided at all costs. + */ + cd->vendor = VENDOR_CYGNAL_85ED; + cd->cdi.mask |= ( + CDC_MULTI_SESSION | + CDC_CLOSE_TRAY | CDC_OPEN_TRAY | + CDC_LOCK | + CDC_GENERIC_PACKET | + CDC_PLAY_AUDIO + ); } #endif } -- 2.23.0