From: Christian Brauner <christian.brauner@ubuntu.com>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: linux-kernel@vger.kernel.org, Joel Fernandes <joel@joelfernandes.org>
Subject: Re: [PATCH] fork: fix pidfd_poll()'s return type
Date: Wed, 20 Nov 2019 01:21:47 +0100 [thread overview]
Message-ID: <20191120002145.skgtkx2f5dxagx4f@wittgenstein> (raw)
In-Reply-To: <20191120000722.30605-1-luc.vanoostenryck@gmail.com>
On Wed, Nov 20, 2019 at 01:07:22AM +0100, Luc Van Oostenryck wrote:
> pidfd_poll() is defined as returning 'unsigned int' but the
> .poll method is declared as returning '__poll_t', a bitwise type.
>
> Fix this by using the proper return type and using the EPOLL
> constants instead of the POLL ones, as required for __poll_t.
>
> CC: Joel Fernandes (Google) <joel@joelfernandes.org>
> CC: Christian Brauner <christian@brauner.io>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Yeah, that makes sense. Thanks.
This only misses two tags:
Fixes: b53b0b9d9a61 ("pidfd: add polling support")
Cc: stable@vger.kernel.org # 5.3
Can you add these two tags to the commit message for v1 and resend with
stable@vger.kernel.org Cced, please?
Otherwise:
Reviewed-by: Christian Brauner <christian.brauner@ubuntu.com>
next prev parent reply other threads:[~2019-11-20 0:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 0:07 Luc Van Oostenryck
2019-11-20 0:21 ` Christian Brauner [this message]
2019-11-20 0:33 ` [PATCH v2] " Luc Van Oostenryck
2019-11-20 10:52 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191120002145.skgtkx2f5dxagx4f@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®