From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Dragan Cvetic <draganc@xilinx.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Derek Kiernan <dkiernan@xilinx.com>
Subject: Re: [PATCH] misc: xilinx_sdfec: fix xsdfec_poll()'s return type
Date: Wed, 20 Nov 2019 19:02:29 +0100 [thread overview]
Message-ID: <20191120180229.frd5padrsdxf7hag@ltop.local> (raw)
In-Reply-To: <CH2PR02MB6359CE45D06E908634CDA855CB4F0@CH2PR02MB6359.namprd02.prod.outlook.com>
On Wed, Nov 20, 2019 at 03:59:24PM +0000, Dragan Cvetic wrote:
> Hi Luc,
>
> For the sake of my understanding I'd like to ask you when the .pole method is defined
> Why I'm asking this? I have a fairly new book (published in 2017) which suggests what is implemented in SDFEC driver.
>
> I'll test your suggestions and will come back to you soon.
Well, yes, it changed in July 2017.
The current definition can be found in include/linux/fs.h:
struct file_operations {
...
__poll_t (*poll) (struct file *, struct poll_table_struct *);
...
The main commit making the change is:
a3f8683bf7d5 ("->poll() methods should return __poll_t")
The result can be verified by compiling the driver with the command
make C=2 path/to/the/driver.o
which will use the static analyser 'sparse' to make additional checks
where the difference between 'unsigned int' and __poll_t will matter.
See Documentation/dev-tools/sparse.rst for more info about it.
Best regards,
-- Luc Van Oostenryck
next prev parent reply other threads:[~2019-11-20 18:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 0:10 Luc Van Oostenryck
2019-11-20 15:59 ` Dragan Cvetic
2019-11-20 18:02 ` Luc Van Oostenryck [this message]
2019-11-20 19:08 ` Dragan Cvetic
2019-11-21 15:39 ` Dragan Cvetic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191120180229.frd5padrsdxf7hag@ltop.local \
--to=luc.vanoostenryck@gmail.com \
--cc=dkiernan@xilinx.com \
--cc=draganc@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®