From: Greg KH <greg@kroah.com>
To: "Enrico Weigelt, metux IT consult" <info@metux.net>
Cc: linux-kernel@vger.kernel.org, balbi@kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] drivers: usb: Kconfig: cleanup indentions
Date: Thu, 21 Nov 2019 17:42:39 +0100 [thread overview]
Message-ID: <20191121164239.GE651886@kroah.com> (raw)
In-Reply-To: <20191121151408.22401-1-info@metux.net>
On Thu, Nov 21, 2019 at 04:14:08PM +0100, Enrico Weigelt, metux IT consult wrote:
> Make the code look a little bit nicer.
That is really vague.
What exactly are you doing here, and why?
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
> drivers/usb/dwc3/Kconfig | 30 +++++++++++++++---------------
> drivers/usb/misc/Kconfig | 24 ++++++++++++------------
> 2 files changed, 27 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index 556a876c7896..7695841a108f 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -97,24 +97,24 @@ config USB_DWC3_KEYSTONE
> Say 'Y' or 'M' here if you have one such device
>
> config USB_DWC3_MESON_G12A
> - tristate "Amlogic Meson G12A Platforms"
> - depends on OF && COMMON_CLK
> - depends on ARCH_MESON || COMPILE_TEST
> - default USB_DWC3
> - select USB_ROLE_SWITCH
> + tristate "Amlogic Meson G12A Platforms"
> + depends on OF && COMMON_CLK
> + depends on ARCH_MESON || COMPILE_TEST
> + default USB_DWC3
> + select USB_ROLE_SWITCH
> select REGMAP_MMIO
I think this change is already in my tree, right? Please don't
duplicate work that others already did.
thanks,
greg k-h
prev parent reply other threads:[~2019-11-21 16:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 15:14 Enrico Weigelt, metux IT consult
2019-11-21 16:42 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121164239.GE651886@kroah.com \
--to=greg@kroah.com \
--cc=balbi@kernel.org \
--cc=info@metux.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®